Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Node.enabledProperty respect pickable:null? #1105

Closed
zepumph opened this issue Oct 30, 2020 · 2 comments
Closed

Should Node.enabledProperty respect pickable:null? #1105

zepumph opened this issue Oct 30, 2020 · 2 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Oct 30, 2020

Over while reviewing changes in #1100 (comment), @samreid and I were curious if it is buggy that enabled can change the pickability from null to true silently and not explicitely. Here is the case we came up with in that comment:

x = new Node();
  x.pickable => null;
  x.enabled => true;
x.enabled = true; // no op
  x.pickable => null; // null right now
  x.enabled => true;
x.enabled = false;
  x.pickable => false;
  x.enabled => false;
x.enabled = true;
  x.pickable => true; // buggy? Is this a discrepancy in behavior? Or perhaps a feature?
  x.enabled => true;

@jonathanolson, can you speak to this at all. Do you foresee any problems coming from toggling into true instead of respecting null?

@jonathanolson
Copy link
Contributor

I generally believe enabledProperty should not change the pickability, AND we wouldn't want to replace things with pickable:true generally.

@zepumph
Copy link
Member Author

zepumph commented Nov 12, 2020

This is going to be covered by phetsims/sun#666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants