From 18b2f071f02607088c3cfe41ff5d732cd1c88d8e Mon Sep 17 00:00:00 2001 From: zepumph Date: Mon, 1 Feb 2021 16:36:32 -0900 Subject: [PATCH] interactive descriptions -> interactive description, https://github.com/phetsims/a11y-research/issues/157 --- doc/accessibility.html | 4 ++-- js/accessibility/pdom/PDOMUtils.js | 2 +- js/nodes/Node.js | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/accessibility.html b/doc/accessibility.html index d9634a91f..a6bc5225a 100644 --- a/doc/accessibility.html +++ b/doc/accessibility.html @@ -644,7 +644,7 @@

PhET Specific Information

Enabling A11y

- Accessibility features are hidden behind an ?supportsDescriptions query parameter. This hides a11y features + Accessibility features are hidden behind an ?supportsDescription query parameter. This hides a11y features until they are ready for production. When ready, accessibility can be enabled by default by adding Sim option accessibility: true to {{sim}}-main.js. @@ -676,7 +676,7 @@

A11y Specific Strings

Beginning a11y work on a sim

- When beginning a11y work in a simulation, add "supportsInteractiveDescriptions": true to the sim's package.json. + When beginning a11y work in a simulation, add "supportsInteractiveDescription": true to the sim's package.json. Then regenerate the lists to add the simulation to perennial/data/interactive-descriptions list, and generate an a11y-view HTML document to assist with development (grunt generate-a11y-view-html).

diff --git a/js/accessibility/pdom/PDOMUtils.js b/js/accessibility/pdom/PDOMUtils.js index 6559d69fa..f66461697 100644 --- a/js/accessibility/pdom/PDOMUtils.js +++ b/js/accessibility/pdom/PDOMUtils.js @@ -308,7 +308,7 @@ const PDOMUtils = { assert && assert( domElement instanceof Element ); // parent to HTMLElement, to support other namespaces assert && assert( typeof textContent === 'string' ); - // TODO: this line must be removed to support i18n Interactive Descriptions, see https://github.com/phetsims/chipper/issues/798 + // TODO: this line must be removed to support i18n Interactive Description, see https://github.com/phetsims/chipper/issues/798 const textWithoutEmbeddingMarks = stripEmbeddingMarks( textContent ); // Disallow any unfilled template variables to be set in the PDOM. diff --git a/js/nodes/Node.js b/js/nodes/Node.js index a41ae3bb2..ece6f99c3 100644 --- a/js/nodes/Node.js +++ b/js/nodes/Node.js @@ -5696,7 +5696,7 @@ Node.DEFAULT_OPTIONS = DEFAULT_OPTIONS; scenery.register( 'Node', Node ); -// Node is composed with this feature of Interactive Descriptions +// Node is composed with this feature of Interactive Description ParallelDOM.compose( Node ); // @public {IOType}