Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should ZoomButtonGroup support magnifying glass icons? #647

Closed
samreid opened this issue Nov 30, 2020 · 6 comments
Closed

Should ZoomButtonGroup support magnifying glass icons? #647

samreid opened this issue Nov 30, 2020 · 6 comments

Comments

@samreid
Copy link
Member

samreid commented Nov 30, 2020

From phetsims/circuit-construction-kit-common#620 "Zoom buttons need magnifying glasses".

Circuit construction kit is using ZoomButtonGroup for the chart zoom in/out buttons, in the aforementioned issue, we said:

From today's design meeting, "+" and "-" are overloaded in CCK, and showing those as button icons without other context will be confusing. We need the magnifying glass icons. This is for the charts and for the play area zoom buttons.

It currently looks like this:

image

Assigning to the primary developer for ZoomButtonGroup for discussion.

@samreid
Copy link
Member Author

samreid commented Nov 30, 2020

I added a comment in phetsims/circuit-construction-kit-common#620 (comment) about what the other zoom buttons in CCK AC look like. Maybe we should wait for a conclusion on that conversation before going too far with this issue.

@pixelzoom pixelzoom assigned samreid and unassigned pixelzoom Nov 30, 2020
@pixelzoom
Copy link
Contributor

Strong push back on adding magnifying glasses to ZoomButtonGroup. This was specifically designed for cases where you do not need (heavyweight) magnifying glasses. If you need magnifying glasses, use ZoomButton.

@samreid
Copy link
Member Author

samreid commented Nov 30, 2020

Are you recommending a parallel implementation of ZoomButtonGroup that uses the magnifying glass icons?

UPDATE: Why not make the icons options that default to "+" and "-"?

@pixelzoom
Copy link
Contributor

UPDATE: Why not make the icons options that default to "+" and "-"?

More complexity, more cost. Imo unnecessary. That's my opinion. If someone wants to add it, go for it -- and please add yourself as @author.

@samreid
Copy link
Member Author

samreid commented Nov 30, 2020

On hold until we have a consensus in phetsims/circuit-construction-kit-common#620

@samreid
Copy link
Member Author

samreid commented Dec 15, 2020

We added support in phetsims/circuit-construction-kit-common#620, closing.

@samreid samreid closed this as completed Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants