-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should ZoomButtonGroup support magnifying glass icons? #647
Comments
I added a comment in phetsims/circuit-construction-kit-common#620 (comment) about what the other zoom buttons in CCK AC look like. Maybe we should wait for a conclusion on that conversation before going too far with this issue. |
Strong push back on adding magnifying glasses to ZoomButtonGroup. This was specifically designed for cases where you do not need (heavyweight) magnifying glasses. If you need magnifying glasses, use ZoomButton. |
Are you recommending a parallel implementation of ZoomButtonGroup that uses the magnifying glass icons? UPDATE: Why not make the icons options that default to "+" and "-"? |
More complexity, more cost. Imo unnecessary. That's my opinion. If someone wants to add it, go for it -- and please add yourself as |
On hold until we have a consensus in phetsims/circuit-construction-kit-common#620 |
We added support in phetsims/circuit-construction-kit-common#620, closing. |
From phetsims/circuit-construction-kit-common#620 "Zoom buttons need magnifying glasses".
Circuit construction kit is using ZoomButtonGroup for the chart zoom in/out buttons, in the aforementioned issue, we said:
It currently looks like this:
Assigning to the primary developer for ZoomButtonGroup for discussion.
The text was updated successfully, but these errors were encountered: