Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale info not getting updated very often on live translation utility #431

Closed
jbphet opened this issue Jun 12, 2024 · 2 comments
Closed
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented Jun 12, 2024

An effort has been underway recently to add translation support for more locales and to improve the fallback handling (there are several issues related to this, a few of the major ones are phetsims/joist#963, https://github.com/phetsims/website-meteor/issues/489, and phetsims/chipper#1441). As part of the effort, changes were made to the shared chipper/data/localeInfo.json file, and Rosetta is supposed to re-read this file periodically from GitHub and thereby auto-update its list of locales. However, when the changes were made, Rosetta didn't update, and I had to manually restart it to get them to show up. I reviewed the log to see if I could determine whether updates to the locale data were occurring, and the were, but pretty infrequently. Here are the two most recent log entries that indicate a re-read of the local info file:

.
.
.
May 17 20:24:05 phet-server2.int.colorado.edu rosetta[166423]: info: locale info is stale or nonexistent; getting it
.
.
.
Jun 02 00:24:45 phet-server2.int.colorado.edu rosetta[166423]: info: locale info is stale or nonexistent; getting it
.
.
.

This is a little over two weeks. I think I should shorten the time.

Note that this value isn't hard-coded into Rosetta, it's a configuration options in the rosetta-config.json file, and the options is called VALID_LOCALE_INFO_DURATION.

@jbphet jbphet self-assigned this Jun 12, 2024
@jbphet
Copy link
Contributor Author

jbphet commented Jun 12, 2024

On phet-server2, where the live instance of Rosetta runs, the configuration file contains the following line:

"VALID_LOCALE_INFO_DURATION": 1209600000,

This value is in milliseconds. I did the conversion, and this is indeed two weeks. I think I'll reduce it to 12 hours.

@jbphet
Copy link
Contributor Author

jbphet commented Jun 12, 2024

I have changed the value in the config file to 43200000, which is 12 hours. I think that should do it, closing.

@jbphet jbphet closed this as completed Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant