Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translators are reporting incorrect percentages in the report #421

Closed
jbphet opened this issue Jul 18, 2023 · 13 comments
Closed

Translators are reporting incorrect percentages in the report #421

jbphet opened this issue Jul 18, 2023 · 13 comments
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented Jul 18, 2023

@solaolateju sent me a Slack message this morning where he said that translators are saying that they are seeing incorrect values for the percentage of strings that are translated. The translators are saying that the utility is reporting less than 100% when all of the strings have been translated.

As an example, he Kikuyu translator (locale = ki) says he/she is seeing this in greenhouse-effect, build-a-molecule, and acid-base-solutions.

@jbphet jbphet self-assigned this Jul 18, 2023
@jbphet
Copy link
Contributor Author

jbphet commented Jul 18, 2023

I can see what they are talking about. If I look at Kikuyu for acid-base-solutions I see this:

image

But when I load the translation page for the sim, all but one string is translated. It also lists the sim as "not yet published in Kikuyu", and I don't see it on the website.

@solaolateju - Can you please ask the translator if they have published the sim by pressing the "Publish" button? Perhaps they are using the translation a little differently or something. If they haven't, please have them do so.

@RVieyra
Copy link

RVieyra commented Jul 21, 2023

We have known for some time that the % Translated Strings is not accurate.

This does not prevent the publication.

And yes, our translators keep pressing "Publish" and it's just not showing up on the website.

We have noted this issue in Shona and Kikuyu.

@solaolateju
Copy link

Screenshot: Acid-base solutions
Locale: Kikuyu

Sorry @jbphet, this notification got drowned in all the GitHub notifications.

Yes, they hit the publish button. I also tested with Kikuyu.

When you hit the publish button, you receive the regular prompt before submission that shows all the strings are translated.
image

Followed by a confirmation of submission.
image

However, the submitted sim stays in the list of "Sims not yet published" and cannot be viewed on the website.

@jbphet
Copy link
Contributor Author

jbphet commented Aug 29, 2023

I just checked the main PhET website and found that the Kikuyu translation of Acid Base solutions is present. I looked at the history of the main translation strings file (acid-base-solutions-strings_ki.json), and it looks like the translator attempted to publish on 7/13/2023 and 7/20/2023. Perhaps the first publication attempt failed for some reason and the second succeeded. The sim is now listed as being published in Kikuyu, here is a screenshot from the translation utility:

image

I think this particular sim/locale is now looking correct, and I'll pursue some of the other issues with mis-reported stats.

@jbphet
Copy link
Contributor Author

jbphet commented Aug 29, 2023

@solaolateju - I just looked at the stats for the Kikuyu translations of greenhouse-effect, build-a-molecule, and acid-base-solutions, which were identified at one point as being incorrect. They all look correct to me. Can you please check and/or have the Kikuyu translator check and see if these issues appear to be resolved?

@jbphet
Copy link
Contributor Author

jbphet commented Aug 30, 2023

@RVieyra said in a previous comment:

We have known for some time that the % Translated Strings is not accurate.

I've tracked down and, I believe, fixed a couple of issue that were causing inaccuracies in the percentage values in the translation reports. I spot tested several simulations in the Kikuyu and Shona locales, and the information was accurate.
@solaolateju and @RVieyra - can you please check this and let me know if the problem appears to have been addressed?

@jbphet jbphet assigned RVieyra and unassigned jbphet Aug 30, 2023
@oliver-phet
Copy link
Contributor

Just adding to this issue that Center and Variability is displaying 216% (in the case of Polish -- fully translated)
image
Spanish is similar:
image

@solaolateju
Copy link

@jbphet we are having new instances of % completion status issue. Please take a look.

@jbphet
Copy link
Contributor Author

jbphet commented Apr 26, 2024

@kathy-phet has let me know that fixing this isn't a priority at the moment. I'll leave it open and will check during planning meetings in the future, but as of now it is unlikely to get much of my attention anytime soon.

@RVieyra
Copy link

RVieyra commented Apr 27, 2024

Understood. We will just let the translators know to ignore the value for now.

@jbphet
Copy link
Contributor Author

jbphet commented Aug 23, 2024

Above, @solaolateju said:

@jbphet we are having new instances of % completion status issue. Please take a look.

I've been allocated a bit of time in the current iteration to work on translation, so I am, indeed, taking a look. I'm testing using the currently live version at https://phet.colorado.edu/translate. I'm looking at the percentage values for Center & Variability for the Polish (pl) and Spanish (es) locales because @oliver-phet reported some specific issues with these, but they seem fine. Here are some screenshots:

Polish C&V:

image

Spanish C&V:

image

The full translation report page for Polish shows everything at 100%. Diligent translator I guess.

Screen capture of full Polish page

screencapture-phet-colorado-edu-translate-pl-2024-08-23-16_41_54

The Spanish (es) translation report page shows some sims that are not fully translated, and I spot checked some of these (Diffusion, Gas Properties, and My Solar System), and the percentage values appear correct.

Screen capture of full Spanish (es) page

screencapture-phet-colorado-edu-translate-es-2024-08-23-16_54_13

The translation report page for Kikuyu shows some sims at 100% and some below. I spot checked several sims (Acid Base Solutions, My Solar System, and Vector Addition), and the values seem correct.

Screen capture of full Kikuyu(ki) page

screencapture-phet-colorado-edu-translate-ki-2024-08-23-17_17_27

The bottom line here is that all my testing of the currently live version shows the percentage values as being accurate. This means that I'll need a bit more information from @oliver-phet, @solaolateju, and/or @RVieyra to figure out why problems are being reported. Are any of you able to come up with example cases where the percentages are incorrect? If so, please provide me with screenshots and as much information as possible with regard to locale, sim, translator, and when they were seeing the problem (local time zone is fine as long as you can tell me where they are so I can convert to GMT. I need this to be able to check Rosetta's logs). Otherwise I'm afraid there isn't much I can do.

@jbphet jbphet assigned oliver-phet and jbphet and unassigned jbphet Aug 23, 2024
@solaolateju
Copy link

@jbphet Thanks for taking a look at this issue again.
I also took a look and everything at first glance all is looking OK now.
Let me check with the network tomorrow and come back after a final check with them.

@jbphet
Copy link
Contributor Author

jbphet commented Oct 25, 2024

I just spoke with @solaolateju over Slack, and he says that it's safe to close this issue now - things seem to be working correctly.

@jbphet jbphet closed this as completed Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants