Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can select disabled Combo Box from PDOM #74

Closed
zepumph opened this issue Jun 22, 2020 · 1 comment
Closed

Can select disabled Combo Box from PDOM #74

zepumph opened this issue Jun 22, 2020 · 1 comment
Assignees
@zepumph
Labels
type:bug Something isn't working

Comments

@zepumph
Copy link
Member

zepumph commented Jun 22, 2020

I looks like ComboBox.enabledProperty is only changing pickability, which works for mouse, but doesn't prevent a11y listeners from firing on the element. @jessegreenberg and I discussed this on slack and decided to pair on this tomorrow.

It may be slightly related to phetsims/sun#462
@zepumph zepumph added the type:bug Something isn't working label Jun 22, 2020
@zepumph zepumph self-assigned this Jun 22, 2020
@zepumph zepumph mentioned this issue Jun 23, 2020
Open
@zepumph
Copy link
Member Author

zepumph commented Jun 23, 2020

This has been solved by phetsims/scenery#1056. Note also that now the button has aria-disabled added to it when disabled.

@zepumph zepumph closed this as completed Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zepumph