Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert individual ratio interactions to sliders #49

Closed
zepumph opened this issue May 13, 2020 · 2 comments
Closed

Convert individual ratio interactions to sliders #49

zepumph opened this issue May 13, 2020 · 2 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented May 13, 2020

This issue will change them from div element with role="application" to be an input of type slider. This is more semantic and make the description easier.

I'm pretty sure that we want to do this, but will assign @emily-phet to double check and for prioritization. My understanding was that we don't need keyboard interaction in the horizontal axis, and so this simplification will help pedagogically and with the implementation.

With this, we will need to work with #35 to implement description with aria-valuetext and aria-live. Not sure which of the two issues to do that work in.

@zepumph
Copy link
Member Author

zepumph commented May 18, 2020

Oops sorry, but over in #47 I already did this conversion. It made implementing the snap logic really easy and nice.

Now what is left in this issue is to implement the appropriate description for the sliders. This means aria-valuetext and potentially some rounding/units too. Assigning to @Matthew-Moore240 for the description support.

@emily-phet
Copy link

Handling description in other issues, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants