Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten both hands description when tick marks are visible by removing distance region #460

Closed
zepumph opened this issue Apr 6, 2022 · 4 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Apr 6, 2022

This info is more redundant, and can be removed. I want to wait until the initial implementation is done over in #432 (comment) item (1).

This should not apply to the description, and it most likely applies to all voicing of both hands, meaning when the ratio is locked + mouse input too. On hold for now though.

@terracoda
Copy link
Contributor

I like the qualitative distance-region info combined with the tick marks. I think we should leave it.

I am not sure how it will work with Media-Pipe, but with Mouse and Ratio Locked it seems fine.

@terracoda
Copy link
Contributor

And with Both Hands and bi-manual input it seems fine. And with the indy sliders with keyboard input are fine, too.

I think the qualitative distance will be helpful for some learners, especially learners with vision impairments or learners with learning disabilities.

@terracoda
Copy link
Contributor

I'll close after I test with media pipe.

@zepumph
Copy link
Member Author

zepumph commented Apr 15, 2022

@terracoda and I discussed this, and we don't think this is needed. This would be a totally fine change, but it is good right now, and there is a chance it would be worse when it was shorter. We have control over toggling the context responses. Closing

@zepumph zepumph closed this as completed Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants