Lines around screen icons persist

[liammulh]

Test Device

iPad Pro

Operating System

iPadOS 14.4

Browser

14.0.3

Problem Description

For phetsims/qa#609. The lines that appear around the screen icons when you hover over them or click them persist. See gif.

Gif

[zepumph]

I don't have time to test right now, but I wonder if this is something to do with our recent changes involving PressListener.looksOverProperty

[zepumph]

I tried reproducing in the RC on my iPad and can't. I press on a screen and then press and drag my finger across the buttons but the highlight works as expected for me. You are on an iPad, but use language that suggests that you may have a mouse plugged in for this test.

Can you please provide some more detailing on how to reproduce?

[liammulh]

@zepumph, I forgot to mention that I was using a stylus. I just checked and I wasn't able to reproduce by tapping with my fingers. Up until now, I haven't seen a stylus-specific bug, so I'll be more cognizant of this in the future.

[liammulh]

I added https://github.com/phetsims/QA/blob/master/documentation/qa-book.md#note-on-tablets. I will message @KatieWoe about this as well.

[zepumph]

See phetsims/scenery#1156 for the common code issue tracking this. In short, this is because there is logic in scenery that is hard coded to only fire if it is a Touch pointer, but we actually want to fire it on Touch OR Pen.

[zepumph]

I think this will be fixed with cherry-picks explained in phetsims/scenery#1156 (comment).

I'll mark this as ready for testing.

[liammulh]

My Apple Pencil is broken. I've ordered a new part for it, but it'll be two days before it gets here. I don't think this should block progress on the spot check since it's such an edge case, @zepumph and @KatieWoe.

[liammulh]

Fixed in phetsims/qa#617.