Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't always hear "go beyond-edge" responses #332

Closed
terracoda opened this issue Jan 12, 2021 · 3 comments
Closed

Don't always hear "go beyond-edge" responses #332

terracoda opened this issue Jan 12, 2021 · 3 comments
Assignees
Labels
type:bug Something isn't working type:wontfix This will not be worked on

Comments

@terracoda
Copy link
Contributor

terracoda commented Jan 12, 2021

The "go beyond edge" responses were verified for keyboard interaction in #247.

However, yesterday while testing with iOS 14.3 and VO on iPhone7, I was not getting responses when the right hand tried to go beyond the top. I did, however, hear the response for the left hand, when trying to go lower than "near bottom".

Today, however, I am having trouble double verifying the behaviour, likely due to changes in phetsims/scenery#1094

@zepumph
Copy link
Member

zepumph commented Jan 14, 2021

I didn't know if this capability was supported on iOS. That said, it is possible that phetsims/scenery#1094 just changed the behavior from what you experienced 2 days ago.

When I am at the border, and I swipe towards the border, I only get the object response. I also tested this behavior in GFLB and got the same behavior on master, as well as with https://phet.colorado.edu/sims/html/gravity-force-lab-basics/latest/gravity-force-lab-basics_en.html.

Basically I thought that the screen reader doesn't provide events to the browser in this case, it just repeats the object response. I could be wrong though. Do you know if we have gotten these on iOS before?

@zepumph zepumph assigned terracoda and unassigned zepumph Jan 14, 2021
@terracoda
Copy link
Contributor Author

Ratio has to be locked to get this response.

On Mac OS no issue
I have verified that the "go beyond edge" responses fire for me when using the keyboard or the mouse on MacOS 10.13.6 (sorry I haven't updated). They fire when using either hand slider, and using either WS keys or Up/Down Arrow keys on the Both Hands interaction. The responses work with mouse and keyboard.

There is something inconsistent when using iOS. Here's my summary.

With VO and Safari on iOS 14.3 (iPhone7)

  • With Numbered Tick Marks selected
    • I always get the beyond-top response ("Right hand at top. Move hands down to explore more.") when I try to go beyond Tick mark 10.
    • However, I never get the beyond-bottom response ("Left hand near bottom. Move hands up to explore more.") when I try to go beyond the lowest possible locked ratio position ("both hands near tick mark zero").
  • With No Tick Marks
    • I never get the beyond-top or beyond-bottom responses
  • With "plain" Tick Marks
    • I never get the beyond-top or beyond-bottom responses

I have verified that it is possible for the response to fire on iOS (using VO swipes) because the beyond-top response fires consistently with Numbered Tick Marks selected.

@zepumph, there seems to be something different going on for the beyond-bottom response when Numbered Tick Marks is selected, and when the other 2 views are selected.

Perhaps, you could verify how it is working for the one case, the beyond-top responses when Numbered Tick Marks is selected?

@terracoda terracoda assigned zepumph and unassigned terracoda Jan 15, 2021
@zepumph
Copy link
Member

zepumph commented Jan 15, 2021

@terracoda and I discussed this together today. We found phetsims/gravity-force-lab-basics#185 (comment) which was this exact question that we discussed when publishing GFLB. Over there @jessegreenberg and I found that VO doesn't give the browser any events when moving "beyond" the min/max of a slider that is currently at that min or max.

Ratio and Proportion is specifically strange when the ratio is locked. This is because you can trigger the "go beyond" alert by moving the "other" hand, which isn't at the mix or max. For example, if the target challenge is 1:2, ratio is locked, and the right hand is at max. In that case moving the left hand up will have VO send an event to the browser to try to move the slider from 5 to 5.5. Then the RaP model will compute it back to 5 to constrain the ratio in range and keep it locked. Because the browser gets input, we will also get the "go beyond" edge alert.

@terracoda and I are happy to have cracked the case on this weirdness, and don't feel like there is anything else to do here. Again I'll tag this as a wontfix.

@zepumph zepumph closed this as completed Jan 15, 2021
@zepumph zepumph added type:wontfix This will not be worked on and removed status:blocks-sim-publication labels Jan 15, 2021
@zepumph zepumph reopened this Jan 15, 2021
@zepumph zepumph closed this as completed Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working type:wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants