Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Context Response when maintaining a Triangle #457

Open
terracoda opened this issue Nov 21, 2023 · 0 comments
Open

Incorrect Context Response when maintaining a Triangle #457

terracoda opened this issue Nov 21, 2023 · 0 comments
Assignees
Labels
dev:maintenance-release type:bug Something isn't working type:question Further information is requested

Comments

@terracoda
Copy link
Contributor

This is not super high priority, but I just noticed that in one case, I am hearing the incorrect shape maintenance response when maintaining a triangle.

The design doc has 2 responses:

  • One for moving the center (180-degree corner) in between the other two corners:
    • {{CornerName}} {{flat}} as adjacent sides change in length.
  • A second for when moving one of the non-180-degree corners:
    • Adjacent sides {{sideLetter}} and {{sideLetter}} in line as shape gets {{bigger/smaller}}.

I hear the correct response for case one, but for case two I only hear the correct response when the triangle is getting bigger. In case two when the triangle gets smaller, I hear the case one response.

There may be an implementation limitation for this. If so, I need to make note of it in the design doc. If not, it would be nice to fix this on the next maintenance release.

To reproduce, make the following triangle and play with corners D, A, and B with a mouse or keyboard.
Screenshot 2023-11-21 at 11 27 34

@terracoda terracoda added type:bug Something isn't working type:question Further information is requested dev:maintenance-release labels Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:maintenance-release type:bug Something isn't working type:question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants