Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion failed #326

Closed
KatieWoe opened this issue Jan 10, 2023 · 18 comments
Closed

Assertion failed #326

KatieWoe opened this issue Jan 10, 2023 · 18 comments
Assignees
Labels
type:bug Something isn't working

Comments

@KatieWoe
Copy link

For phetsims/qa#879. Seen on Win 11 Chrome.
When running a fuzz test on the debug version of the sim, these assertion failed errors occurred.
bug

@KatieWoe KatieWoe added the type:bug Something isn't working label Jan 10, 2023
@jessegreenberg
Copy link
Contributor

Uh oh...thanks @KatieWoe. This probably isn't sim specific, Ill take a look.

@jessegreenberg
Copy link
Contributor

I have been fuzzing master and 1.0.0-dev.73 debug build for about 10 minutes and haven't seen this yet. @KatieWoe is this issue rare for you or does it happen quickly on your platform?

@jessegreenberg
Copy link
Contributor

I let master and https://phet-dev.colorado.edu/html/quadrilateral/1.0.0-dev.73/phet/quadrilateral_all_phet_debug.html fuzz with ?brand=phet&ea&debugger&fuzz for ~3 hours this evening and did not see this issue.

I expected this error to show up before phetsims/utterance-queue#97 (changes made last week) but don't understand how it could show up now.

@KatieWoe are you able to see this consistently? Any extra query parameters?

@jessegreenberg jessegreenberg removed their assignment Jan 11, 2023
@KatieWoe
Copy link
Author

KatieWoe commented Jan 11, 2023

This is the link I used: https://phet-dev.colorado.edu/html/quadrilateral/1.0.0-dev.73/phet/quadrilateral_all_phet_debug.html?fuzz. I was able to reproduce the assertion within 10 minutes, but I'm not sure what's causing it. The only thing I can think of was that I did enable sound by clicking on the sim as it was loading.

@jessegreenberg
Copy link
Contributor

Ill try again and think on race conditions that might cause this assertion to appear again...

@jessegreenberg jessegreenberg self-assigned this Jan 11, 2023
@brettfiedler
Copy link
Member

Just a data point - let that link above run for 20+ minutes and no crashing (Chrome, win10)

@KatieWoe
Copy link
Author

Clarification, the sim didn't seem to crash. It kept going after these errors popped up in the console

@jessegreenberg
Copy link
Contributor

Thats good to know @KatieWoe, thanks. I was also running with the console open and did not see any assertions come thorugh.

@brettfiedler
Copy link
Member

Clarification, the sim didn't seem to crash. It kept going after these errors popped up in the console

Gotcha, thanks. Trying again.

@brettfiedler
Copy link
Member

Again, just a single data point update, over an hour and no assertion raised in console.

@jessegreenberg
Copy link
Contributor

Over slack @KatieWoe said that she was not able to replicate on Win 10. Then she tested the same test with a recent build of RaP on Win 11 and was NOT able to see it in ~10 minutes of fuzzing.

@jessegreenberg
Copy link
Contributor

@KatieWoe can you please try on win 11 quad master with assertions enabled and the console open? If it happens can you please paste an image of the error from the console? Hopefully with the console open the sim will freeze the first time it happens.

@jessegreenberg
Copy link
Contributor

@KatieWoe was able to see this on master in an unbuilt sim wiht ?ea and found this ouput which is not too helpful unfortunately:
image

I am not sure what else to try at this time so its back to be to think through why this would happen in utterance-queue code.

@Nancy-Salpepi
Copy link

I was able to get the same assertion error this morning with mac + chrome while running a fuzz test. I went back and recorded my screen and slowed it down as much as I could. It seems to involve the About dialog, but I haven't been able to replicate the error on my own (without ?fuzz).

assertionerror.mp4

@jessegreenberg
Copy link
Contributor

jessegreenberg commented Jan 12, 2023

After the above comment and finding phetsims/joist#898, I am curious if this is actually related to Chrome 109 and that joist issue.

EDIT: Confirmed! After upgrading to 109.0.5414.75 I hit this in a few minutes of fuzzing.

@jessegreenberg
Copy link
Contributor

phetsims/joist#898 has been fixed and I believe that change will fix this problem as well.

I let the sim fuzz for ~40 minutes in Chrome 109 and I am not seeing this issue. @KatieWoe would you mind trying again on master?

@KatieWoe
Copy link
Author

Things are ok for me now.

@KatieWoe KatieWoe assigned jessegreenberg and unassigned KatieWoe Jan 17, 2023
@jessegreenberg
Copy link
Contributor

That is great news, thanks. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants