diff --git a/js/quadrilateral/QuadrilateralQueryParameters.ts b/js/quadrilateral/QuadrilateralQueryParameters.ts index c7f92f66..1c5e7179 100644 --- a/js/quadrilateral/QuadrilateralQueryParameters.ts +++ b/js/quadrilateral/QuadrilateralQueryParameters.ts @@ -118,6 +118,8 @@ const QuadrilateralQueryParameters = QueryStringMachine.getAll( { // QuadrilateralSoundOptionsModel.SoundDesign as a string. See https://github.com/phetsims/quadrilateral/blob/master/js/quadrilateral/model/QuadrilateralSoundOptionsModel.ts#L37-L53 soundDesign: { type: 'string', + + // REVIEW: This value doesn't seem to be cased like other query parameter values defaultValue: 'TRACKS_LAYER', validValues: SoundDesign.enumeration.keys }, diff --git a/js/quadrilateral/model/QuadrilateralShapeDetector.ts b/js/quadrilateral/model/QuadrilateralShapeDetector.ts index 5c233a00..e30dc494 100644 --- a/js/quadrilateral/model/QuadrilateralShapeDetector.ts +++ b/js/quadrilateral/model/QuadrilateralShapeDetector.ts @@ -29,10 +29,10 @@ import NamedQuadrilateral from './NamedQuadrilateral.js'; const CONCAVE = Math.pow( 2, 0 ); const ONE_PARALLEL_PAIR = Math.pow( 2, 1 ); const TWO_PARALLEL_PAIR = Math.pow( 2, 2 ); -const TWO_EQUAL_ADJACENT_ANGLE_PAIR = Math.pow( 2, 4 ); +const TWO_EQUAL_ADJACENT_ANGLE_PAIR = Math.pow( 2, 4 ); // REVIEW: Are we skipping 3? const ONE_EQUAL_OPPOSITE_ANGLE_PAIR = Math.pow( 2, 5 ); const TWO_EQUAL_OPPOSITE_ANGLE_PAIR = Math.pow( 2, 6 ); -const ALL_EQUAL_ANGLE = Math.pow( 2, 7 ); +const ALL_EQUAL_ANGLE = Math.pow( 2, 7 );// REVIEW: Are we skipping 8? const TWO_EQUAL_ADJACENT_SIDE_PAIR = Math.pow( 2, 9 ); const ONE_EQUAL_OPPOSITE_SIDE_PAIR = Math.pow( 2, 10 ); const TWO_EQUAL_OPPOSITE_SIDE_PAIR = Math.pow( 2, 11 ); @@ -100,6 +100,8 @@ export default class QuadrilateralShapeDetector { this.quadrilateralShapeModel = quadrilateralShapeModel; } + // REVIEW: This method should be made static, and pass in the QuadrilateralShapeModel as an argument + // REVIEW: Add some unit tests to make sure this method and the masks are working as expected /** * Compute the name of the quadrilateral. Note this must be called AFTER all order dependent Properties are updated * because it relies on vertex positions to be stable and all shape attributes to be calculated. See diff --git a/js/quadrilateral/model/QuadrilateralVisibilityModel.ts b/js/quadrilateral/model/QuadrilateralVisibilityModel.ts index 44712c4e..47d20691 100644 --- a/js/quadrilateral/model/QuadrilateralVisibilityModel.ts +++ b/js/quadrilateral/model/QuadrilateralVisibilityModel.ts @@ -20,6 +20,7 @@ export default class QuadrilateralVisibilityModel { public readonly vertexLabelsVisibleProperty: BooleanProperty; // Whether the grid is visible. + // REVIEW: Should and other boolean options start with "is"? public readonly gridVisibleProperty: BooleanProperty; // Whether the diagonal guides are visible.