Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance Release: Fixing alerts after Chrome update #614

Closed
7 tasks done
jessegreenberg opened this issue Feb 22, 2021 · 8 comments
Closed
7 tasks done

Maintenance Release: Fixing alerts after Chrome update #614

jessegreenberg opened this issue Feb 22, 2021 · 8 comments

Comments

@jessegreenberg
Copy link
Contributor

jessegreenberg commented Feb 22, 2021

This is a batch of maintenance releases for the issue identified in phetsims/utterance-queue#16. A change to Chrome made it so that all alerts stopped being spoken after about 5 alerts. Please spend 30-60 seconds with each link making sure that nothing is obviously broken. Then for the PhET brand links can you please check to make sure that screen reader alerts are coming through consistently on JAWS in Chrome and VoiceOver in Safari? Thanks! Let me know if you have any questions.

Assigning to @KatieWoe and @kathy-phet to prioritize.

gravity-force-lab 2.2 (phetsims/utterance-queue#16)

gravity-force-lab-basics 1.0 (phetsims/utterance-queue#16)

molarity 1.5 (phetsims/utterance-queue#16)

molecules-and-light 1.5 (phetsims/utterance-queue#16)

ohms-law 1.4 (phetsims/utterance-queue#16)

@jessegreenberg
Copy link
Contributor Author

Also just notifying @emily-phet and @terracoda so you are aware of this request.

@KatieWoe
Copy link
Contributor

Alerts seem ok on all sims with Win 10 Chrome + Jaws. I did notice that on Molecules and light, it seemed a bit more difficult to switch between light sources.

@terracoda
Copy link
Contributor

Interesting Chrome has sonification on sliders when VO is enabled for that browser. I was just exploring GFL regular. Alerts worked great.

I tested GFL regular on Safari & VO on Mac OS High Sierra 10.13.6. It's never sounded so good! Responses did not conk out at all!

@jessegreenberg
Copy link
Contributor Author

Great, thanks for spot checking @terracoda.

@KatieWoe I just tried the radio buttons with MAL with JAWS. I think what is happening is phetsims/a11y-research#54 (comment), JAWS reads through radio buttons rather than automatically select them with arrow keys. But @KatieWoe if you think it is something else let me know.

@terracoda
Copy link
Contributor

terracoda commented Feb 23, 2021

Unrelated to @KatieWoe's commented since I am spot checking with VO & Chrome on MacOS, but for the record I didn't seem to have any trouble with the radio buttons in MAL. I did notice, however, that in Chrome VO says "bullet" 3 times whereas in Safari says "bullet" 2 times on lists of radio buttons.

Maybe we should find some time to make to make a decision on some of the investigation that has been done on the styling of bulleted lists in phetsims/a11y-research#158

Responses are awesome for me in MAL using Chrome and Safari suing VO.

@KatieWoe
Copy link
Contributor

QA is done

@jessegreenberg
Copy link
Contributor Author

Thanks @KatieWoe - new issues and comments are unrelated to this change so I am going to proceed with the redeploy.

@jessegreenberg
Copy link
Contributor Author

This can be closed, will track deploy to production in phetsims/utterance-queue#16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants