Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Test: waves-intro/1.1.0-dev.24 #511

Closed
6 tasks done
samreid opened this issue Jun 23, 2020 · 11 comments
Closed
6 tasks done

Dev Test: waves-intro/1.1.0-dev.24 #511

samreid opened this issue Jun 23, 2020 · 11 comments
Assignees
Labels
QA:dev-test Dev test before an RC

Comments

@samreid
Copy link
Member

samreid commented Jun 23, 2020

@emily-phet, @jbphet, @ariel-phet, @KatieWoe, @Ashton-Morris, waves-intro/1.1.0-dev.24 is ready for dev testing. Document issues in https://github.com/phetsims/wave-interference/issues and link to this issue. After this dev test, we would like to move toward RC testing and publication. I reached out to @emily-phet about deadlines and clients but have not heard back yet.

Assigning @ariel-phet for prioritization.

UPDATE: I published a fresh version (dev.24) since dev.23 became stale.

General Dev Test

What to Test

  • Click every single button.
  • If there is sound, make sure it works.
  • Make sure you can't lose anything.
  • Play with the sim normally.
  • Try to break the sim.
  • Try to include browser version numbers
  • If there is a console available, check for errors and include them in the Problem Description.
  • Run through the string tests on at least one platform, especially if it is about to go to rc.

Focus and Special Instructions

This is the first release with sonification and keyboard navigation. Please test all sound effects, and test using
keyboard navigation to interact with the sim (in addition to testing mouse/touch as per usual). This version does
not have screen reader support.

General Dev Test Platforms

  • Latest macOS, Chrome and Safari
  • Latest iOS, Safari
  • Windows 10, all browsers
  • Latest Chrome OS, Chrome

Issues to Verify

These issues should have either use the labels "status:ready-for-qa" or "status:ready-for-review." If it is ready for QA then close the issue if fixed. If ready for review then leave open and assign back to the developer.

Link(s)


Accessibility (a11y) Dev Test

Keyboard Navigation

This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself (but not with a screen reader).

FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.


@ariel-phet ariel-phet added the QA:dev-test Dev test before an RC label Jun 23, 2020
@ariel-phet
Copy link
Contributor

There are several high priority items in QA currently so it would be good to hear back from @emily-phet on deadlines/milestones before assigning priority.

@emily-phet
Copy link

@ariel-phet - this sim does not have a hard deadline for publication. Please weave it into the QA queue as it makes sense to you, given the other priorities.

@ariel-phet
Copy link
Contributor

@KatieWoe lets currently slate this work until after #507 and #509 are completed.

@emily-phet
Copy link

@ariel-phet
Can you provide any estimate as to when this might get worked on? The queue looks pretty packed to me, but I don't see it much so not sure what's typical.

There's still no hard deadline for it, but I will still need to report on it's timeline, etc., in grant reports, so best if it's not hanging out in limbo where it's just low-priority enough that it won't get worked on in the foreseeable future.

@ariel-phet
Copy link
Contributor

@emily-phet unlikely to get any attention until after mid-September at the earliest.

@ariel-phet ariel-phet removed their assignment Aug 13, 2020
@samreid
Copy link
Member Author

samreid commented Aug 26, 2020

This version is stale, please let me know when this comes up in the QA queue and I'll post a fresh version.

@samreid samreid changed the title Dev Test: waves-intro/1.1.0-dev.23 Dev Test: waves-intro/1.1.0-dev.24 Oct 13, 2020
@samreid
Copy link
Member Author

samreid commented Oct 13, 2020

From phetsims/waves-intro#19 (comment)

I tested master for a few minutes and did not see any obvious defects. The blocks-publication issues appear not to affect this sim (I tested a screenshot on Chrome and it seemed OK, and there is no stopwatch that changes units).

I published a version here: https://phet-dev.colorado.edu/html/waves-intro/1.1.0-dev.24/phet/waves-intro_en_phet.html

@KatieWoe
Copy link
Contributor

QA is done

@samreid
Copy link
Member Author

samreid commented Oct 28, 2020

Thanks, I'll look into the opened issues. Closing.

@samreid samreid closed this as completed Oct 28, 2020
@samreid samreid reopened this Oct 28, 2020
@samreid
Copy link
Member Author

samreid commented Oct 28, 2020

It's unclear how this issue should appear in the project board. Should it be open or closed, and should it be moved to another column or removed from the project board, or remain in the current column?

@KatieWoe
Copy link
Contributor

I already moved it to "dev ready for next steps" which is where it should be now. The issue is up to you to close when you don't need it anymore. That aspect hasn't changed from before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA:dev-test Dev test before an RC
Projects
None yet
Development

No branches or pull requests

4 participants