Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC test: Area Model Algebra 1.1.0-rc.2 #228

Closed
jonathanolson opened this issue Nov 30, 2018 · 11 comments
Closed

RC test: Area Model Algebra 1.1.0-rc.2 #228

jonathanolson opened this issue Nov 30, 2018 · 11 comments
Assignees

Comments

@jonathanolson
Copy link
Contributor

jonathanolson commented Nov 30, 2018

@kathy-phet, @amanda-phet, area-model-algebra/1.1.0-rc.2 is ready for RC testing. Document issues in https://github.com/phetsims/area-model-common/issues and link to this issue.

Assigning @ariel-phet for prioritization.

General RC Test

What to Test

  • Click every single button.
  • Test all possible forms of input.
    • Test all mouse/trackpad inputs.
    • Test all touchscreen inputs.
  • If there is sound, make sure it works.
  • Make sure you can't lose anything.
  • Play with the sim normally.
  • Try to break the sim.
  • Test all query parameters on all platforms. (See QA Book for a list of query parameters.)
  • Download HTML on Chrome and iOS.
  • Make sure the iFrame version of the simulation is working as intended on all platforms.
  • Make sure the XHTML version of the simulation is working as intended on all platforms.
  • Complete the test matrix.
  • Don't forget to make sure the sim works with Legends of Learning.
  • Check this LoL spreadsheet and notify AR if it not there.
  • If this is rc.1 please do a memory test.

Link(s)


FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.


@pixelzoom
Copy link
Contributor

@KatieWoe @jonathanolson FYI... This RC, and all of the other 1.1.0-rc.1 RCs for the Area Model suite, will not run on iPad2. Some incompatible ES6 code was added that won't run on iPad2 (or other browsers that aren't ES6 compatible), see phetsims/joist#539 (comment).

@jonathanolson
Copy link
Contributor Author

https://phet-dev.colorado.edu/html/area-model-algebra/1.1.0-rc.2/phet/area-model-algebra_en_phet.html (rc.2) should have the patch. Should this issue be updated to just test rc.2?

@KatieWoe
Copy link
Contributor

KatieWoe commented Dec 3, 2018

We haven't yet started on this one, so yes.

@jonathanolson jonathanolson changed the title RC test: Area Model Algebra 1.1.0-rc.1 RC test: Area Model Algebra 1.1.0-rc.2 Dec 3, 2018
@ariel-phet
Copy link
Contributor

@KatieWoe since Area Model is already published (and seems to be working without issue) this testing is a lower priority. Area Model was originally published without a formal code review to meet some grant deadlines, so 1.1.0 allows us to properly finish our process. But again, the live sim is working just fine.

Of the Area Model "suite" this sim should be tested first since the others are mainly a subset of this one.

@ariel-phet ariel-phet assigned KatieWoe and unassigned ariel-phet Dec 4, 2018
@ariel-phet
Copy link
Contributor

@KatieWoe one other comment - as a general rule of thumb, for this particular testing of the Area Model suite any "new" sims are going to take precedence (ie Graphing Quadratics, Coulomb's law, EFAC, etc)

@KatieWoe
Copy link
Contributor

Memory Results (I activated sound during fuzz so that source of leak did not come in to play):
Start: 57 MB
1 min: 70.5
2: 71.8
3: 73.3
4: 74.0
5: 76.2
6: 75.3
7: 75.6
8: 75.8
9: 76.3
10: 76.5

@KatieWoe
Copy link
Contributor

https://github.com/phetsims/graphing-lines/issues/116 was seen again in this game. I assume this is because the sim still uses vibe?

@jonathanolson
Copy link
Contributor Author

This release branch had patches related to phetsims/chipper#720 and phetsims/brand#34 applied since the last RC. This sim should have another RC done, if only to test the brand-related changes briefly.

@mattpen
Copy link
Contributor

mattpen commented Apr 26, 2019

This branch was patched as part of the batch maintenance release in phetsims/chipper#746. This should just have added a .gz file to the build artifacts.

@KatieWoe
Copy link
Contributor

KatieWoe commented May 1, 2019

QA is done per @ariel-phet

@jonathanolson
Copy link
Contributor Author

Thanks. I'll have another RC deploy (from new SHAs off of master) soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants