-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RC test: Area Model Algebra 1.1.0-rc.2 #228
Comments
@KatieWoe @jonathanolson FYI... This RC, and all of the other 1.1.0-rc.1 RCs for the Area Model suite, will not run on iPad2. Some incompatible ES6 code was added that won't run on iPad2 (or other browsers that aren't ES6 compatible), see phetsims/joist#539 (comment). |
https://phet-dev.colorado.edu/html/area-model-algebra/1.1.0-rc.2/phet/area-model-algebra_en_phet.html (rc.2) should have the patch. Should this issue be updated to just test rc.2? |
We haven't yet started on this one, so yes. |
@KatieWoe since Area Model is already published (and seems to be working without issue) this testing is a lower priority. Area Model was originally published without a formal code review to meet some grant deadlines, so 1.1.0 allows us to properly finish our process. But again, the live sim is working just fine. Of the Area Model "suite" this sim should be tested first since the others are mainly a subset of this one. |
@KatieWoe one other comment - as a general rule of thumb, for this particular testing of the Area Model suite any "new" sims are going to take precedence (ie Graphing Quadratics, Coulomb's law, EFAC, etc) |
Memory Results (I activated sound during fuzz so that source of leak did not come in to play): |
https://github.com/phetsims/graphing-lines/issues/116 was seen again in this game. I assume this is because the sim still uses vibe? |
This release branch had patches related to phetsims/chipper#720 and phetsims/brand#34 applied since the last RC. This sim should have another RC done, if only to test the brand-related changes briefly. |
This branch was patched as part of the batch maintenance release in phetsims/chipper#746. This should just have added a .gz file to the build artifacts. |
QA is done per @ariel-phet |
Thanks. I'll have another RC deploy (from new SHAs off of master) soon. |
@kathy-phet, @amanda-phet, area-model-algebra/1.1.0-rc.2 is ready for RC testing. Document issues in https://github.com/phetsims/area-model-common/issues and link to this issue.
Assigning @ariel-phet for prioritization.
General RC Test
What to Test
Link(s)
FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.
How should I format my issue?
Here's a template for making issues:
Who should I assign?
We typically assign the developer who opened the issue in the QA repository.
My question isn't in here... What should I do?
You should:
The text was updated successfully, but these errors were encountered: