Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev test: Coulomb's Law 1.0.0-dev.19 #203

Closed
6 tasks done
mbarlow12 opened this issue Oct 3, 2018 · 15 comments
Closed
6 tasks done

Dev test: Coulomb's Law 1.0.0-dev.19 #203

mbarlow12 opened this issue Oct 3, 2018 · 15 comments
Assignees
Labels
QA:dev-test Dev test before an RC

Comments

@mbarlow12
Copy link

mbarlow12 commented Oct 3, 2018

@arouinfar , @emily-phet , @jessegreenberg coulombs-law/1.0.0-dev.19 is ready for dev testing. Document issues in https://github.com/phetsims/coulombs-law/issues and link to this issue.

Assigning @ariel-phet for prioritization.

General Dev Test

What to Test

  • Click every single button.
  • If there is sound, make sure it works.
  • Make sure you can't lose anything.
  • Play with the sim normally.
  • Try to break the sim.

General Dev Test Platforms

  • Latest macOS, Chrome, Firefox, and Safari
  • Latest iOS, Safari
  • Windows 10, all browsers
  • Latest Chrome OS, Chrome

Issues to Verify

These issues should have the "status:fixed-pending-testing" label. Check these issues off and close them if they are fixed. Otherwise, post a comment in the issue saying that it wasn't fixed.

Link(s)


Accessibility (a11y) Dev Test

What to Test

  • Specific instructions can be found below.
  • Make sure the a11y feature doesn't negatively affect the sim in any way.

Focus and Special Instructions

See the issues below, but please pay special attention to keyboard navigation within Firefox.

Issues to Verify

Please note that this hasn't been specifically fixed as we couldn't really ascertain the cause. We opted to push its full fix to 1.1, but it would be useful to know if this is still persisting and any more details that we may not have gathered in the first round.

Link(s)

Keyboard Navigation

This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a screen reader.


FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.


@arouinfar
Copy link
Contributor

It's super exciting to see CL moving into QA testing!

@mbarlow12 it was my understanding that CL would be published without any a11y features. While it's true that keyboard navigation is functional with ?accessibility, it's missing the keyboard dialog (phetsims/coulombs-law#58 (comment)) and there's a also a known keyboard nav issue with the ruler (phetsims/coulombs-law#41). Both of these issues were deferred until version 1.1+. Perhaps this issue should be amended to remove a11y testing.

@arouinfar
Copy link
Contributor

Well, it looks like I commented a bit soon, my bad. I didn't see the separate a11y links. Definitely seems reasonable for QA to test keyboard nav, so long as @KatieWoe and team are aware of the scope.

@ariel-phet ariel-phet added QA:dev-test Dev test before an RC priority:2-high labels Oct 4, 2018
@ariel-phet
Copy link
Contributor

@KatieWoe this task is similar priority to #199 since both are new sims, and this would be an exiting one to get published.

@ariel-phet ariel-phet assigned KatieWoe and unassigned ariel-phet Oct 4, 2018
@mbarlow12
Copy link
Author

@arouinfar Thanks for the notice. I'd missed the keyboard help dialog. I'll add that today, update the dev release and the issue here.

@arouinfar
Copy link
Contributor

@mbarlow12 since keyboard nav is deferred until 1.1, I'm not sure that the dialog is necessary, but I'll leave it up to you.

@emily-phet
Copy link

emily-phet commented Oct 4, 2018

I may be mis-remembering, but I believe a11y features were deferred because there was some urgency to get additional sims out for the start (or at least, early part of) the Fall start to school. Since that's not the case now, I don't see any reason to defer deploying with keyboard nav, if all it takes is adding in the already designed dialog, and QA testing keyboard nav. If significant issues come up in QA testing, we can triage from there and decide to defer at that point if necessary.

Does this seem reasonable @ariel-phet ?

@arouinfar
Copy link
Contributor

That all sounds reasonable to me @emily-phet, so long as @mbarlow12 has the bandwidth for it.

@KatieWoe
Copy link
Contributor

KatieWoe commented Oct 5, 2018

QA is done

@KatieWoe KatieWoe removed their assignment Oct 5, 2018
@mbarlow12
Copy link
Author

@KatieWoe after the updates from @jessegreenberg in phetsims/john-travoltage#317, is the full screen IE issue resolved for CL and GFL(:B)?

If so, then with the ruler dragging deferred to 1.1, I'd say we can move on to the next stage.

@mbarlow12 mbarlow12 assigned mbarlow12 and KatieWoe and unassigned mbarlow12 Oct 10, 2018
@KatieWoe
Copy link
Contributor

@mbarlow12 phetsims/john-travoltage#317 (comment)
Yes it should be resolved for both sims.

@mbarlow12
Copy link
Author

@ariel-phet do I have the go ahead to move into RC testing?

@mbarlow12 mbarlow12 assigned ariel-phet and unassigned KatieWoe Oct 11, 2018
@ariel-phet
Copy link
Contributor

@mbarlow12 sort of....I don't see the keyboard dialog?

Could you publish a version that includes the keyboard dialog...I don't see it when I run
https://phet-dev.colorado.edu/html/coulombs-law/1.0.0-dev.19/phet/coulombs-law_all_phet.html?accessibility

Please publish a dev version that includes that, and have @arouinfar do a quick spot check of the dialog, and if all looks good feel free to move onto RC. Make sure the RC also includes a check of the projector mode.

@ariel-phet ariel-phet assigned arouinfar and unassigned ariel-phet Oct 12, 2018
@mbarlow12
Copy link
Author

@arouinfar @ariel-phet here's a new dev version with the keyboard help dialog.

https://phet-dev.colorado.edu/html/coulombs-law/1.0.0-dev.20/phet/coulombs-law_en_phet.html

Let me know what tweaks need to be made before heading to RC.

@arouinfar
Copy link
Contributor

Looks good @mbarlow12!

@arouinfar arouinfar removed their assignment Oct 15, 2018
@phet-steele
Copy link
Contributor

RC in #210.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA:dev-test Dev test before an RC
Projects
None yet
Development

No branches or pull requests

6 participants