-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev test: Coulomb's Law 1.0.0-dev.19 #203
Comments
It's super exciting to see CL moving into QA testing! @mbarlow12 it was my understanding that CL would be published without any a11y features. While it's true that keyboard navigation is functional with |
Well, it looks like I commented a bit soon, my bad. I didn't see the separate a11y links. Definitely seems reasonable for QA to test keyboard nav, so long as @KatieWoe and team are aware of the scope. |
@arouinfar Thanks for the notice. I'd missed the keyboard help dialog. I'll add that today, update the dev release and the issue here. |
@mbarlow12 since keyboard nav is deferred until 1.1, I'm not sure that the dialog is necessary, but I'll leave it up to you. |
I may be mis-remembering, but I believe a11y features were deferred because there was some urgency to get additional sims out for the start (or at least, early part of) the Fall start to school. Since that's not the case now, I don't see any reason to defer deploying with keyboard nav, if all it takes is adding in the already designed dialog, and QA testing keyboard nav. If significant issues come up in QA testing, we can triage from there and decide to defer at that point if necessary. Does this seem reasonable @ariel-phet ? |
That all sounds reasonable to me @emily-phet, so long as @mbarlow12 has the bandwidth for it. |
QA is done |
@KatieWoe after the updates from @jessegreenberg in phetsims/john-travoltage#317, is the full screen IE issue resolved for CL and GFL(:B)? If so, then with the ruler dragging deferred to 1.1, I'd say we can move on to the next stage. |
@mbarlow12 phetsims/john-travoltage#317 (comment) |
@ariel-phet do I have the go ahead to move into RC testing? |
@mbarlow12 sort of....I don't see the keyboard dialog? Could you publish a version that includes the keyboard dialog...I don't see it when I run Please publish a dev version that includes that, and have @arouinfar do a quick spot check of the dialog, and if all looks good feel free to move onto RC. Make sure the RC also includes a check of the projector mode. |
@arouinfar @ariel-phet here's a new dev version with the keyboard help dialog. https://phet-dev.colorado.edu/html/coulombs-law/1.0.0-dev.20/phet/coulombs-law_en_phet.html Let me know what tweaks need to be made before heading to RC. |
Looks good @mbarlow12! |
RC in #210. |
@arouinfar , @emily-phet , @jessegreenberg coulombs-law/1.0.0-dev.19 is ready for dev testing. Document issues in https://github.com/phetsims/coulombs-law/issues and link to this issue.
Assigning @ariel-phet for prioritization.
General Dev Test
What to Test
General Dev Test Platforms
Issues to Verify
These issues should have the "status:fixed-pending-testing" label. Check these issues off and close them if they are fixed. Otherwise, post a comment in the issue saying that it wasn't fixed.
Link(s)
Accessibility (a11y) Dev Test
What to Test
Focus and Special Instructions
See the issues below, but please pay special attention to keyboard navigation within Firefox.
Issues to Verify
Please note that this hasn't been specifically fixed as we couldn't really ascertain the cause. We opted to push its full fix to 1.1, but it would be useful to know if this is still persisting and any more details that we may not have gathered in the first round.
Link(s)
Keyboard Navigation
This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a screen reader.
FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.
How should I format my issue?
Here's a template for making issues:
Who should I assign?
We typically assign the developer who opened the issue in the QA repository.
My question isn't in here... What should I do?
You should:
The text was updated successfully, but these errors were encountered: