Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC Test: Resistance In A Wire 1.5.0-rc.5 #125

Closed
13 tasks done
zepumph opened this issue May 31, 2018 · 12 comments
Closed
13 tasks done

RC Test: Resistance In A Wire 1.5.0-rc.5 #125

zepumph opened this issue May 31, 2018 · 12 comments

Comments

@zepumph
Copy link
Member

zepumph commented May 31, 2018

@jessegreenberg, @ariel-phet, @emily-phet, @terracoda, @phet-steele, Resistance in a Wire 1.5.0-rc.5 is ready for RC testing.

NOTE: This is the THIRD rc, despite the naming. The last round of rc testing only found 2 issues, and only one needed to be fixed for this rc, so in my mind this seems more like a spot check than another fully round of rc testing, although I defer to @ariel-phet's judgement.

Link to sim

Link to iFrame

Before beginning, please familiarize yourself with how a screen reader works. Here is a page with information about PhET's supported screen readers and documentation about how to use them:
Screen reader intro

The simulation to test has labels and/or descriptions. They can be "seen" here:
Link to a11y view

This view shows what is available to a screen reader user. The sim is on the left side in an iframe, while the right side has all of the accessible descriptions. Beneath the sim are real-time alerts that will be announced by the screen reader. Please make sure that the descriptions on the right accurately describe the simulation at all times.

PhET supports the following platforms for accessibility so please test these:
(These should be in the test matrix)

  • JAWS with latest Windows, latest Firefox
  • NVDA with latest Windows, latest Firefox
  • VoiceOver with latest macOS, latest Safari

Please also verify

  • stringTest=double (all strings doubled)
  • stringTest=long (exceptionally long strings)
  • stringTest=X (short strings)
  • stringTest=rtl (right-to-left)
  • stringTest=xss (test passes if sim does not redirect, OK if sim crashes or fails to fully start)
  • showPointerAreas (touchArea=red, mouseArea=blue)
  • Full screen test
  • Screenshot test
  • Does AR need to be notified for any LOL updates?

Accessibility strings that are not visible should not be translatable yet, do not worry if these do not change with string tests.

If any new issues are found, please note them in https://github.com/phetsims/resistance-in-a-wire/issues and reference this issue.

Critical screen reader information

(Other potentially useful items)

Please make sure that the following issues are fixed:

@ariel-phet please assign and prioritize

@phet-steele
Copy link
Contributor

phet-steele commented May 31, 2018

I think you meant to mention @lmulhall-phet, not me!

@ghost ghost self-assigned this May 31, 2018
@ariel-phet
Copy link
Contributor

@lmulhall-phet please make this the current top testing priority

@ariel-phet ariel-phet removed their assignment May 31, 2018
@phet-steele
Copy link
Contributor

phet-steele commented May 31, 2018

@zepumph you asked for (and labeled this) as a spot check, yet still linked a desire for a test matrix. We only use a test matrix for a full RC, so can we remove this? Similar story with all the stringTest tests and screenshot test, etc. Can we remove those too?

@zepumph
Copy link
Member Author

zepumph commented May 31, 2018

@lmulhall-phet @phet-steele, @jessegreenberg and I think that this is good for just a spot check, I removed the matrix above. Thanks for all the patience as I learn the qa work flow.

@zepumph
Copy link
Member Author

zepumph commented Jun 1, 2018

I will copy commits from phetsims/chipper#673 to fix this rc branches a11y view, sorry that it is broken.

@ghost
Copy link

ghost commented Jun 5, 2018

QA is done.

@ghost ghost removed the priority:1-top label Jun 5, 2018
@phet-steele phet-steele assigned zepumph and unassigned ghost Jun 5, 2018
@zepumph
Copy link
Member Author

zepumph commented Jun 8, 2018

Alright it looks like we are ready for a new version to test. I think I will add fixes for phetsims/resistance-in-a-wire#150 and phetsims/chipper#673 and ask for a spot check test next. @jessegreenberg @phet-steele @lmulhall-phet let me know if you think this warrants a 4th rc test instead (if you could call this one an rc test).

@zepumph zepumph closed this as completed Jun 8, 2018
@zepumph zepumph reopened this Jun 8, 2018
@ghost
Copy link

ghost commented Jun 12, 2018

@zepumph, I'd like to do one more RC before we publish just to make sure it's spick and span. Just my two cents.

@jessegreenberg
Copy link
Contributor

I think another spot check like this one sounds good, in particular to hammer away at changing the letter sizes for phetsims/resistance-in-a-wire#150.

@terracoda
Copy link
Contributor

Spot check sounds good, and is there a time frame? I assume this sim is still priority 1.

@zepumph
Copy link
Member Author

zepumph commented Jun 13, 2018

Yes, I will get a new version out hopefully today.

@zepumph
Copy link
Member Author

zepumph commented Jun 14, 2018

@zepumph zepumph closed this as completed Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants