Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataProbe "sensing tolerance" should respect zoom #275

Open
zepumph opened this issue Sep 7, 2021 · 3 comments
Open

DataProbe "sensing tolerance" should respect zoom #275

zepumph opened this issue Sep 7, 2021 · 3 comments

Comments

@zepumph
Copy link
Member

zepumph commented Sep 7, 2021

Over in #153, we want to greatly increase the maximum that zoom-out that can occur, but one of the main barriers for it from a usability standpoint is the ability for the data probe to detect the points on a trajectory. If we have the sensing logic account for the current zoom, then this problem will be accounted for, and adjusted for all zoom levels, not just the ones added over in #153.

Over here I will just work on the refactor of zoom. This will involve moving the zoomProperty over to the model so that the DataProbe's calculations can utilize it. It shouldn't be too hard, but it will change the PhET-iO instrumentation as well, making it model.zoomProperty instead of in the viewProperties.

@zepumph
Copy link
Member Author

zepumph commented Sep 7, 2021

@arouinfar please review this as you review #153 in general. Please note the change of zoomProperty from the view to the model (especially for PhET-iO).

@arouinfar
Copy link
Contributor

Projectile Motion is an "if-time" quarterly goal, so marking as on-hold.

@arouinfar
Copy link
Contributor

Unassigning myself until work on this flavor of Projectile Motion resumes.

@arouinfar arouinfar removed their assignment Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants