Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CODAP] Unchecking and then rechecking variable doesn't restore data in copy/saved version #359

Open
Nancy-Salpepi opened this issue Oct 22, 2024 · 2 comments
Assignees
Labels
type:bug Something isn't working

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air M1 chip

Operating System
15.0.1

Browser
Safari 18.0.1

Problem description
For phetsims/qa#1157, if I uncheck and then check any previously checked variables in a saved or copy version, when the column reappears it is blank.

Steps to reproduce

  1. Check all the setup variables
  2. Collect some data on any screen
  3. Save or Make a Copy
  4. In the saved version/copy uncheck one of the variables -- column disappears in the table
  5. Recheck that variable -- column reappears but the data is lost

Visuals

blank.column.mp4
@Nancy-Salpepi Nancy-Salpepi added the type:bug Something isn't working label Oct 22, 2024
@samreid
Copy link
Member

samreid commented Nov 8, 2024

Save or Make a Copy

I believe @matthew-blackman and I observed that in "Save" or "Make a Copy", CODAP manages the data in the table and we do not have control over repopulating it correctly. (It is more like a "deep copy" than a live dynamical wired-up view). This solved some problems but created other problems.

@samreid
Copy link
Member

samreid commented Nov 11, 2024

@matthew-blackman indicated there is a chance that the "hidden" strategy in #357 may solve this. But that depends on the "hidden" values coming along with the copy. If they do, it will work properly. If they don't, we will have to investigate writing our own workaround for that. Or an updated way of dealing with the sparse data model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants