-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No grab/release sounds for the stopwatch and measuring tape. #270
Comments
If you don't want default grab/release sounds, would it be possible to add this to PDLStopwatchNode? Then I could continue with phetsims/scenery-phet#845. dragListenerOptions: {
grabSound: null,
releaseSound: null
},
keyboardDragListenerOptions: {
grabSound: null,
releaseSound: null
} |
Adding grab/release sound to MeasuringTapeNode is also pretty trivial, see phetsims/scenery-phet#846. |
@samreid and I discussed, and I'll proceed with adding default grab/release sounds to StopwatchNode and MeasuringTapeNode. I'll notify @samreid and @matthew-blackman when this work is completed -- probably on Monday 3/25. Your options for this sim:
|
@samreid @matthew-blackman FYI, work has been completed for default grab/release sounds in StopwatchNode and MeasuringTapeNode. |
Looks good and working well in my testing. I believe this issue can be closed. |
There are no default grab/release sounds for the stopwatch and measuring tape. My understanding is that we're adding these to all new sims that support UI sound. And it involves a quick conversion to RichDragListener and RichKeyboardDragListener.
The conversion for StopwatchNode can be found in the patch in phetsims/scenery-phet#845 (comment). I have not committed it because it would seem even more odd for the measuring tape to have no grab/release sound.
The text was updated successfully, but these errors were encountered: