diff --git a/js/common-vsm/model/VSMModel.ts b/js/common-vsm/model/VSMModel.ts index 8311ba38..30373ff2 100644 --- a/js/common-vsm/model/VSMModel.ts +++ b/js/common-vsm/model/VSMModel.ts @@ -42,6 +42,8 @@ export type VSMModelOptions = SelfOptions & StrictOmit extends PDLModel { + //REVIEW Declarations of BooleanProperty should be Property + // Static tool visibility public readonly isLaunchAngleVisibleProperty: BooleanProperty; public readonly isLaunchSpeedVisibleProperty: BooleanProperty; diff --git a/js/common-vsm/view/InteractiveToolPanel.ts b/js/common-vsm/view/InteractiveToolPanel.ts index 361e8668..c357f511 100644 --- a/js/common-vsm/view/InteractiveToolPanel.ts +++ b/js/common-vsm/view/InteractiveToolPanel.ts @@ -36,7 +36,7 @@ export type InteractiveToolPanelOptions = SelfOptions & WithRequired isStopwatchVisibleProperty: PhetioProperty, providedOptions: InteractiveToolPanelOptions ) { diff --git a/js/common/model/Field.ts b/js/common/model/Field.ts index 52fd2b01..de987438 100644 --- a/js/common/model/Field.ts +++ b/js/common/model/Field.ts @@ -86,7 +86,7 @@ export default abstract class Field extends PhetioObject { public readonly launchHeightProperty: TReadOnlyProperty; // True if the continuous mode is set to launching or false if not launching - public readonly isContinuousLaunchingProperty: BooleanProperty; + public readonly isContinuousLaunchingProperty: BooleanProperty; //REVIEW should be Property // An array of projectiles that are currently in the air. Note: No projectile should be in the airborneProjectiles and landedProjectiles array simultaneously. public readonly airborneProjectiles: Projectile[] = []; diff --git a/js/common/model/PDLEventTimer.ts b/js/common/model/PDLEventTimer.ts index 2205e5e0..8f8f7a47 100644 --- a/js/common/model/PDLEventTimer.ts +++ b/js/common/model/PDLEventTimer.ts @@ -21,7 +21,7 @@ export default class PDLEventTimer { private readonly period: number; // Whether the timer is running - private readonly isRunningProperty: BooleanProperty; + private readonly isRunningProperty: BooleanProperty; //REVIEW should be Property // Remaining time until the next event, in seconds private readonly timeRemainingProperty: NumberProperty; diff --git a/js/common/model/PDLModel.ts b/js/common/model/PDLModel.ts index 60554166..fe1af133 100644 --- a/js/common/model/PDLModel.ts +++ b/js/common/model/PDLModel.ts @@ -63,7 +63,7 @@ export default abstract class PDLModel implements TModel { public readonly singleOrContinuousProperty: Property; // Setting for whether the user wants to see the paths of the projectiles - public readonly isPathsVisibleProperty: BooleanProperty; + public readonly isPathsVisibleProperty: BooleanProperty; //REVIEW should be Property // Abstract Property that indicates the selected Launcher public readonly abstract launcherProperty: TReadOnlyProperty; diff --git a/js/measures/model/MeasuresModel.ts b/js/measures/model/MeasuresModel.ts index c3ad88f2..52f8f085 100644 --- a/js/measures/model/MeasuresModel.ts +++ b/js/measures/model/MeasuresModel.ts @@ -44,6 +44,8 @@ export default class MeasuresModel extends SMModel { // Whether the launcher is custom or mystery public readonly mysteryOrCustomProperty: DynamicProperty; + //REVIEW Declarations of BooleanProperty should be Property + // Whether the mean is visible on the field and histogram public readonly isMeanVisibleProperty: BooleanProperty; diff --git a/js/measures/view/DataMeasuresOverlay.ts b/js/measures/view/DataMeasuresOverlay.ts index 7bab711f..f76076a1 100644 --- a/js/measures/view/DataMeasuresOverlay.ts +++ b/js/measures/view/DataMeasuresOverlay.ts @@ -52,6 +52,7 @@ export default class DataMeasuresOverlay extends Node { public constructor( modelViewTransform: ModelViewTransform2 | ChartTransform, meanDistanceProperty: PhetioProperty, standardDeviationDistanceProperty: PhetioProperty, + //REVIEW next 3 params of type BooleanProperty should be TReadOnlyProperty isMeanDisplayedProperty: BooleanProperty, isStandardDeviationDisplayedProperty: BooleanProperty, isValuesDisplayedProperty: BooleanProperty, diff --git a/js/measures/view/MeasuresHistogramNode.ts b/js/measures/view/MeasuresHistogramNode.ts index 685c6c0d..245e6975 100644 --- a/js/measures/view/MeasuresHistogramNode.ts +++ b/js/measures/view/MeasuresHistogramNode.ts @@ -42,6 +42,7 @@ export default class MeasuresHistogramNode extends VSMHistogramNode { numberOfLandedProjectilesProperty: TReadOnlyProperty, histogram: Histogram, horizontalAxisLabelText: TReadOnlyProperty, + //REVIEW next 3 params of type BooleanProperty should be TReadOnlyProperty isMeanVisibleProperty: BooleanProperty, isStandardDeviationVisibleProperty: BooleanProperty, isValuesVisibleProperty: BooleanProperty, diff --git a/js/measures/view/MeasuresInteractiveToolPanel.ts b/js/measures/view/MeasuresInteractiveToolPanel.ts index 046c460d..52a8ae8f 100644 --- a/js/measures/view/MeasuresInteractiveToolPanel.ts +++ b/js/measures/view/MeasuresInteractiveToolPanel.ts @@ -26,9 +26,9 @@ type MeasuresInteractiveToolPanelOptions = SelfOptions & InteractiveToolPanelOpt export default class MeasuresInteractiveToolPanel extends InteractiveToolPanel { public constructor( - isMeasuringTapeVisibleProperty: BooleanProperty, + isMeasuringTapeVisibleProperty: BooleanProperty, //REVIEW should be Property isStopwatchVisibleProperty: PhetioProperty, - isIntervalToolVisibleProperty: BooleanProperty, + isIntervalToolVisibleProperty: BooleanProperty, //REVIEW should be Property providedOptions: MeasuresInteractiveToolPanelOptions ) { class IntervalToolIcon extends Node {