-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decide on PDOM Labels and navigation order #105
Comments
@amanda-phet Note: the latest link to plinko with keyboard nav, and with the a11y-view is at the top of the doc. I've removed the table - it was too constraining. Instead, I laid out the entire content of the PDOM - including the interactive elements. I think this will make it much easier to understand -in context - how the description pieces (labels, etc.) will be navigated and perceived. Color coding:
Please take a look, and let me and @terracoda know if you have any questions. |
Status update:
|
The title of this issue indicates "complete by Feb. 15th", presumably 2018. @emily-phet what is the status? |
@pixelzoom, from Plinko's A11y Design doc, I can see that significant progress on labels were made on this sim earlier in the year by @amanda-phet with help from myself and @emily-phet. Perhaps @emily-phet could comment on the priority and @amanda-phet could comment on where she thinks about the state of the static descriptions for this sim. |
@amanda-phet, I'll un-assign myself for now. Let me know if you need feedback or assistance. |
@pixelzoom Amanda would know the latest on this. We didn't make the original deadline (obviously!) . This sim is named in a funded grant that will be worked on over the next three years, so we'll make more progress on this likely after work on GFL:B. Were you working on this sim? I don't see this issue ever assigned to you, so can you comment if this impacts you? |
@emily-phet asked:
I'm the responsible developer for this sim, see https://github.com/phetsims/phet-info/blob/master/sim-info/responsible_dev.md. One of the responsibilities is periodically reviewing GitHub issues. |
@pixelzoom Cool beans. Inaccurate deadline removed from issue name. |
We'll need labels for all of the controls in the sim that you navigate to. The labels should give some indication of what the feature is/does.
Will need collaboration from @amanda-phet and @terracoda to do this.
Design doc, with list of the objects that need labels can be found here. See tables in section "Tab order & Outline".
Edited to add: Also need @amanda-phet to sign off on navigation order. This is indicated by the order of labels in the doc linked above.
The text was updated successfully, but these errors were encountered: