Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on PDOM Labels and navigation order #105

Open
emily-phet opened this issue Jan 9, 2018 · 8 comments
Open

Decide on PDOM Labels and navigation order #105

emily-phet opened this issue Jan 9, 2018 · 8 comments
Assignees

Comments

@emily-phet
Copy link

emily-phet commented Jan 9, 2018

We'll need labels for all of the controls in the sim that you navigate to. The labels should give some indication of what the feature is/does.

Will need collaboration from @amanda-phet and @terracoda to do this.

Design doc, with list of the objects that need labels can be found here. See tables in section "Tab order & Outline".

Edited to add: Also need @amanda-phet to sign off on navigation order. This is indicated by the order of labels in the doc linked above.

@emily-phet emily-phet changed the title Decide on PDOM Labels Decide on PDOM Labels and navigation order Jan 9, 2018
@emily-phet
Copy link
Author

@amanda-phet
I updated the sim's a11y design doc based on our conversation today, and to set up a structure for your draft of labels, help text, and some static descriptions.

Note: the latest link to plinko with keyboard nav, and with the a11y-view is at the top of the doc.

I've removed the table - it was too constraining. Instead, I laid out the entire content of the PDOM - including the interactive elements. I think this will make it much easier to understand -in context - how the description pieces (labels, etc.) will be navigated and perceived.

Color coding:

  • blue indicates something I would like you to consider and edit as needed. Placeholder text is "YYY" and "Y".
  • red indicates a comment from me
  • there are a few google doc comments regarding navigation order

Please take a look, and let me and @terracoda know if you have any questions.

@emily-phet
Copy link
Author

Status update:

  • Amanda added content to draft outline, awaiting feedback
    @terracoda let's discuss this briefly regarding feedback for Amanda.

@emily-phet emily-phet changed the title Decide on PDOM Labels and navigation order Decide on PDOM Labels and navigation order - complete by Feb. 15th Feb 3, 2018
@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 16, 2018

The title of this issue indicates "complete by Feb. 15th", presumably 2018. @emily-phet what is the status?

@terracoda
Copy link

terracoda commented Jul 16, 2018

@pixelzoom, from Plinko's A11y Design doc, I can see that significant progress on labels were made on this sim earlier in the year by @amanda-phet with help from myself and @emily-phet.

Perhaps @emily-phet could comment on the priority and @amanda-phet could comment on where she thinks about the state of the static descriptions for this sim.

@terracoda
Copy link

@amanda-phet, I'll un-assign myself for now. Let me know if you need feedback or assistance.

@terracoda terracoda removed their assignment Jul 16, 2018
@emily-phet
Copy link
Author

@pixelzoom Amanda would know the latest on this. We didn't make the original deadline (obviously!) . This sim is named in a funded grant that will be worked on over the next three years, so we'll make more progress on this likely after work on GFL:B.

Were you working on this sim? I don't see this issue ever assigned to you, so can you comment if this impacts you?

@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 17, 2018

@emily-phet asked:

Were you working on this sim? I don't see this issue ever assigned to you, so can you comment if this impacts you?

I'm the responsible developer for this sim, see https://github.com/phetsims/phet-info/blob/master/sim-info/responsible_dev.md. One of the responsibilities is periodically reviewing GitHub issues.

@emily-phet emily-phet changed the title Decide on PDOM Labels and navigation order - complete by Feb. 15th Decide on PDOM Labels and navigation order Jul 17, 2018
@emily-phet
Copy link
Author

@pixelzoom Cool beans. Inaccurate deadline removed from issue name.

@emily-phet emily-phet removed their assignment Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants