diff --git a/checklists/code_review_checklist.md b/checklists/code_review_checklist.md index 4723939f..2e238961 100644 --- a/checklists/code_review_checklist.md +++ b/checklists/code_review_checklist.md @@ -208,10 +208,11 @@ For a sim repository named “my-repo”, the general structure should look like - [ ] Does `implementation-notes.md` adequately describe the implementation, with an overview that will be useful to future maintainers? - [ ] Sim-specific query parameters (if any) should be identified and documented in one .js file in js/common/ or js/ (if there is no common/). The .js file should be named `{{PREFIX}}QueryParameters.js`, for example ArithmeticQueryParameters.js for the aritmetic repository, or FBQueryParameters.js for Function Builder (where the `FB` prefix is used). - [ ] Query parameters that are public-facing should be identified using `public: true` in the schema. -- [ ] All sims should use a color file named MyRepoColorProfile.js or, if using abbreviations, MRColorProfile.js, and - use ProfileColorProperty where appropriate, even if they have a single (default) profile. - See https://github.com/phetsims/scenery-phet/issues/642 - and https://github.com/phetsims/scenery-phet/issues/515. Please see gas-properties/js/common/GasPropertiesColors.js +- [ ] All sims should use a color file named `MyRepoColors.js` or, if using abbreviations, `MRColors.js`, and + use `ProfileColorProperty` where appropriate, even if they have a single (default) profile (to support color editing + and PhET-iO Studio). The `ColorProfile` pattern was converted to `*Colors.js` files in + https://github.com/phetsims/scenery-phet/issues/515. Please see + [GasPropertiesColors.js](https://github.com/phetsims/gas-properties/blob/master/js/common/GasPropertiesColors.js) for a good example. ## **Coding Conventions**