From c8bebd6a82b4ebf2e2b801fd0ef0c5bab031e18d Mon Sep 17 00:00:00 2001 From: Jesse Date: Fri, 28 Jun 2019 19:59:47 -0400 Subject: [PATCH] Add step to run accessible HTML through validator, see phetsims/gravity-force-lab-basics#156 --- checklists/code_review_checklist.md | 1 + 1 file changed, 1 insertion(+) diff --git a/checklists/code_review_checklist.md b/checklists/code_review_checklist.md index 0011b7c5..ed75ed18 100644 --- a/checklists/code_review_checklist.md +++ b/checklists/code_review_checklist.md @@ -550,6 +550,7 @@ Because JavaScript lacks visibility modifiers (public, protected, private), PhET ## **Accessibility** - [ ] Does the sim pass an accessibility fuzz test? (run with query parameters `fuzzBoard&ea`) +- [ ] Run the accessible HTML through an [HTML validator](https://validator.w3.org/nu/#textarea), does the HTML pass? - [ ] Are accessibility features integrated well into the code. They should be added in a maintainable way, even if that requires upfront refactoring. - [ ] Are accessible design patterns used, see [accessible-design-patterns.md](https://github.com/phetsims/phet-info/blob/master/doc/accessible-design-patterns.md) - [ ] Does resetting the simulation also reset the entire PDOM?