From 9cddf1f3f6d0a5d395fe45d62f1d70ab69ee0546 Mon Sep 17 00:00:00 2001 From: samreid Date: Mon, 16 Nov 2020 08:26:22 -0700 Subject: [PATCH] Add a checklist item about using EnabledProperty, see https://github.com/phetsims/axon/issues/340 --- checklists/code_review_checklist.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/checklists/code_review_checklist.md b/checklists/code_review_checklist.md index 639deb35..87129be8 100644 --- a/checklists/code_review_checklist.md +++ b/checklists/code_review_checklist.md @@ -697,3 +697,5 @@ determining whether `toStateObject` should use `null` or `undefined` values. - [ ] PhET prefers to use the term "position" to refer to the physical (x,y) position of objects. This applies to both brands, but is more important for the PhET-iO API. See https://github.com/phetsims/phet-info/issues/126 - [ ] Are your IOType state methods violating the API of the core type by accessing private fields? +- [ ] When defining a boolean Property to indicate whether something is enabled, use `AXON/EnabledProperty`. This +should be done in both the model and the view.