From 3630b76c83280198e56c5751087079b787073e39 Mon Sep 17 00:00:00 2001 From: samreid Date: Mon, 19 Jul 2021 10:41:59 -0600 Subject: [PATCH] Document new color filename convention, see https://github.com/phetsims/scenery-phet/issues/515 --- checklists/code_review_checklist.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/checklists/code_review_checklist.md b/checklists/code_review_checklist.md index 71316b5f..4ecdcc4b 100644 --- a/checklists/code_review_checklist.md +++ b/checklists/code_review_checklist.md @@ -208,9 +208,9 @@ For a sim repository named “my-repo”, the general structure should look like - [ ] Does `implementation-notes.md` adequately describe the implementation, with an overview that will be useful to future maintainers? - [ ] Sim-specific query parameters (if any) should be identified and documented in one .js file in js/common/ or js/ (if there is no common/). The .js file should be named `{{PREFIX}}QueryParameters.js`, for example ArithmeticQueryParameters.js for the aritmetic repository, or FBQueryParameters.js for Function Builder (where the `FB` prefix is used). - [ ] Query parameters that are public-facing should be identified using `public: true` in the schema. -- [ ] All sims should use a color file and ProfileColorProperty where appropriate, even if they have a single (default) - profile. See https://github.com/phetsims/scenery-phet/issues/642. - TODO: https://github.com/phetsims/scenery-phet/issues/515 decide the name for the colors file. +- [ ] All sims should use a color file named MyRepoColors.js or, if using abbreviations, MyRepoColors.js, and use + ProfileColorProperty where appropriate, even if they have a single (default) profile. See https://github.com/phetsims/scenery-phet/issues/642 + and https://github.com/phetsims/scenery-phet/issues/515 ## **Coding Conventions**