From 277c1a5b6ae0d4d5c73f60500ea6f09810b40b64 Mon Sep 17 00:00:00 2001 From: Chris Malley Date: Mon, 8 Jun 2020 10:33:20 -0600 Subject: [PATCH] #88 --- checklists/code_review_checklist.md | 1 + 1 file changed, 1 insertion(+) diff --git a/checklists/code_review_checklist.md b/checklists/code_review_checklist.md index 06e85ecc..875ffdc0 100644 --- a/checklists/code_review_checklist.md +++ b/checklists/code_review_checklist.md @@ -648,6 +648,7 @@ Because JavaScript lacks visibility modifiers (public, protected, private), PhET - [ ] Does the organization and structure of the code make sense? Do the model and view contain types that you would expect (or guess!) by looking at the sim? Do the names of things correspond to the names that you see in the user interface? - [ ] Are appropriate design patterns used? See [phet-software-design-patterns.md](https://github.com/phetsims/phet-info/blob/master/doc/phet-software-design-patterns.md). If new or inappropriate patterns are identified, create an issue. - [ ] Is inheritance used where appropriate? Does the type hierarchy make sense? +- [ ] Is composition favored over inheritance where appropriate? See https://en.wikipedia.org/wiki/Composition_over_inheritance. - [ ] Is there any unnecessary coupling? (e.g., by passing large objects to constructors, or exposing unnecessary properties/functions) - [ ] Is there too much unnecessary decoupling? (e.g. by passing all of the properties of an object independently instead of passing the object itself)? - [ ] Are the source files reasonable in size? Scrutinize large files with too many responsibilities - can responsibilities be broken into smaller delegates?