-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit usage of navigator userAgent, appVersion, and platform #90
Comments
Just noting the parts from https://blog.chromium.org/2021/05/update-on-user-agent-string-reduction.html that I found important: Regarding timeline:
Regarding compatibility:
I don't see anything in platform.js about Chrome version number, OS version number, or Android device model. So we may be OK with this change. But adding to developer meeting to review with the team and check if anything should be done. |
I noted that there are numerous usages of |
Discussed 8/19/21 at developer meeting: It doesn't seem like we are using the features of the user agent strings that are being changed. According to https://blog.chromium.org/2021/05/update-on-user-agent-string-reduction.html there will be a trail version that we can test before the change goes live. When that is ready we can do some testing to make sure everything is still running OK. @jonathanolson mentioned there might be some impacts on yotta but there likely isn't much we can do about it. We added a reminder to the dev meeting doc to see if a Trail version of chrome with this change is ready yet since there aren't any dates listed in https://blog.chromium.org/2021/05/update-on-user-agent-string-reduction.html for when that will happen. |
Bringing back up to dev meeting. |
According to https://blog.chromium.org/2021/09/user-agent-reduction-origin-trial-and-dates.html and https://developer.chrome.com/blog/user-agent-reduction-origin-trial/ We can register for a trail version with user agent reduction here: https://developer.chrome.com/origintrials/#/view_trial/-7123568710593282047 We have until April 19th 2022 to register. |
We We feel like this is worthy of discussion, but want to wait for @jonathanolson to be present. Before next week we would like to register in the link above, thanks for doing that @jessegreenberg. MK sees that chrome's message recommends navigator.userAgentData, but @samreid mentioned that it is not broadly supported by browsers. We will discuss next week! |
We do NOT want to register PhET for a trail, apparently that impacts all users of our origin!
But I think we can register localhost and use that to test locally. |
High priority to make sure we get to this next week. |
So I thought by "registering" we would be able to download a trial version of Chrome. But you actually have to enable this feature with a response header from your own server. So here are the steps I took to be able to test this. I had to modify the source of
And I can see a difference in the user agent string, such as the minor version of Chrome being |
I don't think we have anything to worry about here for sims. Here is the best list I found with examples about what is changing: https://www.chromium.org/updates/ua-reduction/#sample-ua-strings-phase-4 To summarize:
Assigning to @jonathanolson to confirm if you agree and also to consider if there are implications for yotta. |
No implications for yotta (we don't use the data that was reduced). I've scanned everything and I agree that this should not affect sims. It looks like our normal detections should work. |
Comments during status meeting today confirmed that this is safe for us, we can close. |
Putting in phet-core because that is where platorm.js lives, but there are usages of these in a few places in the project.
@Nancy-Salpepi noticed this warning while testing involving a reduction in the amount of information available in the User Agent string.
Here is information from Chrome about the changes and timeline: https://blog.chromium.org/2021/05/update-on-user-agent-string-reduction.html
The text was updated successfully, but these errors were encountered: