Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pH Scale 1.5 release (6/30/2021) #209

Closed
pixelzoom opened this issue Jan 14, 2021 · 12 comments
Closed

pH Scale 1.5 release (6/30/2021) #209

pixelzoom opened this issue Jan 14, 2021 · 12 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jan 14, 2021

In July 2020, we set a goal of publishing pH Scale 1.4.0, the first production version with PhET-iO. About a month later, we abandoned that effort (and the 1.4 branch) because there were too many PhET-iO changes. See #166.

We'll try again in pH Scale 1.5, and this issue will track that release.

From the note in the QA Pipeline:

pH Scale 1.5.0-rc.1

  • 10/23/20 status update from KP:

pH Scale is now downgraded to "nice to have" but not urgent. I would keep that on hold for now until the new sims are through QA, unless there is a QA lull.

  • new 1.5 branch
  • brands=phet,phet-io
  • full dev + RC QA process
  • also includes ph-scale-basics

From 1/14/2021 PhET-iO meeting, milestones are to begin QA 4/1/21, publish 5/15/21.

1.5 will be a new release branch. It will require a full dev test, and full RC test.

FYI @arouinfar @kathy-phet

@pixelzoom pixelzoom self-assigned this Jan 14, 2021
@pixelzoom pixelzoom changed the title pH Scale 1.5 release pH Scale 1.5 release (5/15/2021) Feb 3, 2021
@pixelzoom
Copy link
Contributor Author

A 4/8/21 Q2 planning meeting, dates were adjusted:

4/1/21 start
5/30/21 end

@pixelzoom pixelzoom changed the title pH Scale 1.5 release (5/15/2021) pH Scale 1.5 release (5/30/2021) Apr 8, 2021
@pixelzoom
Copy link
Contributor Author

Status: There is 1 issue (#215) remaining for review before QA process could being. QA will be a full dev + RC process. So 5/30/21 (3 weeks) is no longer a realistic publication date. Assigning to @kathy-phet and @arouinfar to establish new milestones.

@pixelzoom pixelzoom assigned kathy-phet and arouinfar and unassigned pixelzoom May 10, 2021
@arouinfar
Copy link
Contributor

@pixelzoom I'll take a look at #215, but https://github.com/phetsims/studio/issues/95 is still a blocking issue. It might be acceptable for a dev test (the behavior in master seems fine), but given the review comments, there will likely be code changes.

I cannot determine a new milestone, so leaving that up to @kathy-phet.

@arouinfar arouinfar removed their assignment May 10, 2021
@pixelzoom pixelzoom self-assigned this May 10, 2021
@pixelzoom
Copy link
Contributor Author

@kathy-phet changed milestones to:

4/1/21 start
6/30/21 end

@pixelzoom pixelzoom changed the title pH Scale 1.5 release (5/30/2021) pH Scale 1.5 release (6/30/2021) May 13, 2021
@pixelzoom
Copy link
Contributor Author

We're now 1 week past the milestone. Assigning to @kathy-phet to revise. Feel free to assign back to me when you're ready to proceed with publishing this release.

@pixelzoom pixelzoom assigned kathy-phet and unassigned kathy-phet and pixelzoom Jul 7, 2021
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jul 7, 2021

The original plan was for a full dev test. @kathy-phet requested a dev-lite test, which I published for QA testing on 7/7/21:

EDIT: The above tests were completed 7/13/21. There were no issues found.

@pixelzoom pixelzoom assigned pixelzoom and unassigned kathy-phet Jul 13, 2021
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jul 13, 2021

RC tests published on 7/13/21, per @arouinfar:

EDIT: These RC tests were completed on 7/22/21. They resulted in 2 PhET-iO issues, 1 common-code issue, and 1 sim-specific issue.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jul 23, 2021

RC tests (spot-check) published on 7/23/21:

EDIT: These RC tests were completed on 7/26/21. 4 issues were verified, 1 failed - #225 is still a problem when dealing with concentrations. ph-scale will require another RC, ph-scale-basics is ready for publication.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jul 26, 2021

RC test (spot-check) published on 7/26/2021:

EDIT: This RC test was completed on 7/27/2021. One issue required reverting a change, see #225.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jul 27, 2021

RC test (spot-check) published on 7/27/2021:

EDIT: This RC test was completed 7/27/2021. 1 issue was verified, 1 new issue was found - #232. Unfortunately, that new issue will require an additional RC for both ph-scale and ph-scale-basics. Next RC is blocked until https://github.com/phetsims/phet-io/issues/1800 is addressed.

@pixelzoom
Copy link
Contributor Author

#232 was closed as "won't fix", so another RC is not necessary. Proceeding with production publication.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jul 27, 2021

Published production versions 1.5.0 on 7/27/21:

% cd ph-scale
% grunt production --branch=1.5 --brands=phet,phet-io
% cd ph-scale-basics
% grunt production --branch=1.5 --brands=phet,phet-io

grunt production prints several reminders. Here's how I addressed them:

If this is a version that will be used with students, then make sure to remove the password protection. See https://github.com/phetsims/phet-io/blob/master/doc/phet-io-security.md for details.

N/A

Make sure that the current level of instrumentation is represented here in the Instrumentation Status Spreadsheet. On the spreadsheet, provide the version number like MAJOR.MINOR (without maintenance number) so that maintenance releases will seamlessly upgrade. Update both the text and the link
https://docs.google.com/spreadsheets/d/18_QNGuVtYtxOEKG9xRBs_PSQpyvzySF1Gk5puR-5Fv4/edit#gid=1881767354
And check that the link in the public-facing document has the correct text and link:
https://docs.google.com/spreadsheets/u/1/d/e/2PACX-1vReSXUUxC63CQCKHIoO6qY4ycWrqgw8eaX25io3_r2hRmO3RbXuyNRRMz5J2C1c5mCN9nxumvrv6snj/pubhtml?gid=2141068918&single=true

Done, added:
https://phet-io.colorado.edu/sims/ph-scale/1.5/
https://phet-io.colorado.edu/sims/ph-scale-basics/1.5/

Make sure the sim is listed in perennial/data/phet-io-api-stable, if it has had a designed production release, and update the checked in API file to match the published version.

Verified that they are listed.

If you are delivering this to a partner, update partners.md (phet-io/doc/partners.md) to show this delivery. Read the intro of the document to make sure that you format the entry correctly.

These sims are not in partners.md, and I don't know what to do here. Tracking in https://github.com/phetsims/phet-io/issues/1804, assigned to PhET-iO team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants