Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dropper: disable dragging without disabling button #141

Closed
pixelzoom opened this issue Mar 9, 2020 · 5 comments
Closed

dropper: disable dragging without disabling button #141

pixelzoom opened this issue Mar 9, 2020 · 5 comments

Comments

@pixelzoom
Copy link
Contributor

Reported by @kathy-phet in #118 (comment):

it is not currently possible to make it unmoveable/unpickable without also making the add liquid button unpickable/not working.

This is dependent on completion of phetsims/scenery#1041.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Mar 11, 2020

In phetsims/scenery#1041 (comment) and phetsims/scenery#1041 (comment), @kathy-phet said that this feature is not a prerequisite to delivering a dev version (due 3/30/2020), and only becomes blocking for the final release (date TBD) if identified by the client.

@pixelzoom
Copy link
Contributor Author

... only becomes blocking for the final release (date TBD) if identified by the client.

The client did not flag this issue in their feedback. @arouinfar @kathy-phet is it still the case that this does NOT need to be addressed for 1.0 publication?

@kathy-phet
Copy link

I think for 1.0 published release we do not need to address this issue.

@pixelzoom
Copy link
Contributor Author

Another way to address this issue would be to attach the DragListener to a subset of the dropper's scenegraph (excluding the button). That would require changing the EyeDropperNode API, and probably changing its internal structure. And then clients would have to use a non-standard way of adding a DragListener to an EyeDropperNode.

Imo, coming up with a way to disable scenery input listeners is still the better approach. Using pickableProperty will always have this general problem, and it's not a great way of disabling interaction, because it forces us to have a pickableProperty for every Node, regardless of whether it's interactive.

@pixelzoom
Copy link
Contributor Author

This was addressed in #215, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants