From fb5e3a12102ea4e8be67c8c45b35ed38528f3eca Mon Sep 17 00:00:00 2001 From: mattpen Date: Mon, 8 Jul 2024 13:25:56 -0600 Subject: [PATCH] changed translations to always build all locales on the build-server phetsims/chipper#1441 --- js/build-server/taskWorker.js | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/js/build-server/taskWorker.js b/js/build-server/taskWorker.js index 3d59adf1..6d6b0927 100644 --- a/js/build-server/taskWorker.js +++ b/js/build-server/taskWorker.js @@ -174,9 +174,13 @@ async function runTask( options ) { } } + const localesArray = typeof ( locales ) === 'string' ? locales.split( ',' ) : locales; + // if this build request comes from rosetta it will have a userId field and only one locale + const isTranslationRequest = userId && localesArray.length === 1 && localesArray[ 0 ] !== '*'; + await releaseBranch.build( { clean: false, - locales: locales, + locales: isTranslationRequest ? '*' : locales, buildForServer: true, lint: false, allHTML: !( chipperVersion.major === 0 && chipperVersion.minor === 0 && brands[ 0 ] !== constants.PHET_BRAND ) @@ -203,10 +207,7 @@ async function runTask( options ) { await devDeploy( checkoutDir, simName, version, chipperVersion, brands, buildDir ); } - const localesArray = typeof ( locales ) === 'string' ? locales.split( ',' ) : locales; - // if this build request comes from rosetta it will have a userId field and only one locale - const isTranslationRequest = userId && localesArray.length === 1 && localesArray[ 0 ] !== '*'; if ( servers.indexOf( constants.PRODUCTION_SERVER ) >= 0 ) { winston.info( 'deploying to production' );