Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portions of frequency values remain after collapsing accordion box #73

Open
Nancy-Salpepi opened this issue Nov 2, 2021 · 3 comments
Open
Labels
priority:5-deferred type:bug Something isn't working

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air (m1 chip)

Operating System
12.0.1

Browser
safari

Problem description
phetsims/qa#724
This is not a major issue, but I thought I would report anyway.
When the Normal Mode Spectrum accordion box is collapsed, remnants from the frequency values are still visible.

Steps to reproduce

  1. Select the One Dimension Screen
  2. Optional: Increase the Number of Masses
  3. Collapse the Normal Modes Spectrum accordion box

Visuals
valueremnants

Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Normal Modes‬ URL: https://phet-dev.colorado.edu/html/normal-modes/1.0.0-dev.5/phet/normal-modes_en_phet.html Version: 1.0.0-dev.5 2021-11-01 21:43:06 UTC Features missing: touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.1 Safari/605.1.15 Language: en-US Window: 1199x701 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 (1.0) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
@Nancy-Salpepi Nancy-Salpepi added the type:bug Something isn't working label Nov 2, 2021
@pixelzoom
Copy link
Contributor

pixelzoom commented Nov 2, 2021

The good news is that this doesn't require an M1 device to reproduce. I can reproduce on my Intel MacBook Pro (16" 2019) with macOS 12.01 + Safari 15.1 (17612.2.9.1.20).

It's interesting that the artifacts are part of the subscript of ω0.

This is another one of those "scenery artifacts" that can't be easily resolved. I could try a different renderer. Or we could just ignore it for the prototype.

@jonathanolson recommendations?

@pixelzoom pixelzoom assigned jonathanolson and unassigned pixelzoom Nov 2, 2021
@arouinfar
Copy link

@pixelzoom I think this is minor enough to ignore for the prototype, but I still think it would be good for @jonathanolson to review since it could be relevant to other sims.

@pixelzoom
Copy link
Contributor

OK. Will not address for the prototype. Labeling as deferred until someone works on this sim for public release.

@jonathanolson jonathanolson removed their assignment Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:5-deferred type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants