Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Particle WebGL resolution should be increased #46

Closed
jonathanolson opened this issue Dec 9, 2014 · 4 comments
Closed

Particle WebGL resolution should be increased #46

jonathanolson opened this issue Dec 9, 2014 · 4 comments
Assignees

Comments

@jonathanolson
Copy link
Contributor

The particles look quite pixelated on my screen, and increasing the resolution should fix it. #45 should be done first, since increasing the texture size may have negative performance implications.

An example particle on my screen:
neuron-particle

@jonathanolson
Copy link
Contributor Author

Also, if it lowers the performance too much, please revert to the original resolution.

For the code review: #29.

@jonathanolson
Copy link
Contributor Author

Additionally, instead of just using gl.LINEAR, we may want mip-maps with a larger texture so it looks good across resolutions.

@AshrafSharf
Copy link

This issue is related to #45 where a suggestion is made to use a single texture (with opacity value given as a shader input). The issue #45 is now closed after an internal discussion.
Now that we are generating different textures based on the scale factor (sort of internally creating MipMap), leaving the gl.LINEAR option as it is. @jonathanolson please advice if it is fine

@jbphet
Copy link
Contributor

jbphet commented Sep 22, 2015

This was addressed when working on #65, closing.

@jbphet jbphet closed this as completed Sep 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants