Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pedigree alleles have inconsistent string lengths #285

Closed
KatieWoe opened this issue Jun 28, 2021 · 1 comment
Closed

Pedigree alleles have inconsistent string lengths #285

KatieWoe opened this issue Jun 28, 2021 · 1 comment

Comments

@KatieWoe
Copy link
Contributor

Test device
Dell and Lovelace
Operating System
Win 10 and ChromeOS
Browser
Chrome
Problem description
For phetsims/qa#662. In published. May not be worth fixing.
The alleles for recessive fur and teeth are larger than the others when strings are doubled.
Steps to reproduce

  1. Go to the second screen with ?stringTest=double
  2. Add mutations to all of the traits
  3. Look at the legend in the pedigree graph

Visuals
oddsizes

Troubleshooting information:

!!!!! DO NOT EDIT !!!!!
Name: ‪Natural Selection‬:‪Natural Selection‬
URL: https://phet-dev.colorado.edu/html/natural-selection/1.4.0-rc.1/phet/natural-selection_all_phet.html?stringTest=double
Version: 1.4.0-rc.1 2021-06-21 23:54:30 UTC
Features missing: applicationcache, applicationcache, touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.114 Safari/537.36
Language: en-US
Window: 1280x657
Pixel Ratio: 1.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}

@pixelzoom
Copy link
Contributor

Allele abbreviations are single characters, so this is not a problem that will occur in practice. Unfortunately we currently have no way to enforce "single character" via Rosetta, so it's possible (though unlikely) that someone could use more than 1 character. If that happens, then this is behaving correctly, as this stringTest demonstrates.

So... Closing at "won't fix".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants