Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor pointer area inconsistency #284

Closed
KatieWoe opened this issue Jun 28, 2021 · 4 comments
Closed

Minor pointer area inconsistency #284

KatieWoe opened this issue Jun 28, 2021 · 4 comments
Assignees
Labels
type:bug Something isn't working

Comments

@KatieWoe
Copy link
Contributor

Test device
Dell
Operating System
Win 10
Browser
Chrome
Problem description
For phetsims/qa#662. In published. Very minor and can probably be closed.
The pointer areas around the sunny/snowy scene buttons are slightly different sizes, with sunny being a bit larger. This is the case no matter which one is selected.

Visuals
sizeofareas

Troubleshooting information:

!!!!! DO NOT EDIT !!!!!
Name: ‪Natural Selection‬
URL: https://phet-dev.colorado.edu/html/natural-selection/1.4.0-rc.1/phet/natural-selection_all_phet.html?showPointerAreas
Version: 1.4.0-rc.1 2021-06-21 23:54:30 UTC
Features missing: applicationcache, applicationcache, touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.114 Safari/537.36
Language: en-US
Window: 1280x657
Pixel Ratio: 1.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}

@KatieWoe KatieWoe added the type:bug Something isn't working label Jun 28, 2021
@pixelzoom
Copy link
Contributor

That's very odd, and a bit concerning since this is handled by common-code RadioButtonGroup. I'll investigate when I return from vacation. In the meantime... @KatieWoe do you see this problem with rectangular radio buttons in any other sims?

@KatieWoe
Copy link
Contributor Author

Not that I've noticed, but I also missed this one for a while since the difference was so slight. So I can't make a guarantee. Do what sims I could check to be sure?

@samreid
Copy link
Member

samreid commented Jul 1, 2021

@arouinfar indicated this is not a blocking problem for this release.

@pixelzoom
Copy link
Contributor

This is a general problem with RectangularRadioButtonGroup, as described in phetsims/sun#708. The problem is very minor in Natural Selection, and does not affect usability, so we're NOT going to fix it in the 1.4 release. It will be fixed in master, and picked up in a future release branch (probably 1.5).

Closing as "won't fix".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants