Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launched Sim on iPadOS 14.0 takes up more than full screen #237

Closed
pixelzoom opened this issue Sep 22, 2020 · 4 comments
Closed

Launched Sim on iPadOS 14.0 takes up more than full screen #237

pixelzoom opened this issue Sep 22, 2020 · 4 comments
Labels
dev:phet-io type:bug Something isn't working

Comments

@pixelzoom
Copy link
Contributor

See https://github.com/phetsims/phet-io-wrappers/issues/377. For phetsims/qa#551.
@zepumph
Copy link
Member

zepumph commented Sep 23, 2020

Ready for cherry-pick, see https://github.com/phetsims/phet-io-wrappers/issues/377#issuecomment-697926530

@zepumph
Copy link
Member

zepumph commented Sep 23, 2020

Make sure that this bug get's double checked by RC.

@pixelzoom pixelzoom self-assigned this Sep 23, 2020
pixelzoom added a commit that referenced this issue Sep 23, 2020
@pixelzoom
https://github.com/phetsims/natural-selection/issues/237
63d129a
pixelzoom added a commit that referenced this issue Sep 23, 2020
@pixelzoom
https://github.com/phetsims/natural-selection/issues/237
8dd7a9c
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Sep 24, 2020 •
edited
Loading

Patched and tested in the 1.2 branch. Ready for testing in the next 1.2 RC.

Verify on iPadOS 14 using these steps:

  1. Go to the wrapper index.
  2. Scroll down and press the "Launch Templated" button (shown below the html template)
  3. In the launched sim, choose a screen on the Home screen
  4. Verify that all parts of the sim UI (including the navigation bar) are fully visible.

@pixelzoom pixelzoom mentioned this issue Sep 25, 2020
Closed
9 tasks
@pixelzoom pixelzoom removed their assignment Sep 25, 2020
@KatieWoe
Copy link
Contributor

This seems fixed in rc.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev:phet-io type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pixelzoom @zepumph @KatieWoe