Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Interaction Hint needed in Screen Summary #306

Closed
terracoda opened this issue Mar 12, 2020 · 5 comments
Closed

New Interaction Hint needed in Screen Summary #306

terracoda opened this issue Mar 12, 2020 · 5 comments
Assignees

Comments

@terracoda
Copy link

Related to #302 (review of PDOM), please update the initial interaction hint from:

  • "Look for photon rate slider to explore. {{If needed, set sim to Play under Timing Controls.}}" to:
  • "Turn light source on to explore. {{Make sure sim is set to Play.}}"

The dynamic parts of the hint are in curly braces, and should work the same as the current implementation.

@jessegreenberg
Copy link
Contributor

The interaction hint in master is currently

Turn light source on to explore.

And the design document currently says

Note: With new UI Context responses for light source button, dynamic help text no longer needed.

@terracoda can you comment on whether this issue can be closed or the dynamic part should still be included?

@terracoda
Copy link
Author

@jessegreenberg, yes, apologies, @Matthew-Moore240 and I just discussed the new context responses today. So if the new context responses will work, we won't need this help text to be dynamic.

I'll mark this issue onhold.

@terracoda
Copy link
Author

terracoda commented Mar 24, 2020

If the context responses are cleared for implementation we can come back to this issue.

@jessegreenberg
Copy link
Contributor

@terracoda @Matthew-Moore240 is this issue still on hold?

@terracoda
Copy link
Author

No stale. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants