Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback wrapper lag #177

Closed
phet-steele opened this issue Apr 2, 2021 · 4 comments
Closed

Playback wrapper lag #177

phet-steele opened this issue Apr 2, 2021 · 4 comments

Comments

@phet-steele
Copy link

I just want to note, that like with some other sims, this sim has some mildy slow performance in the playback wrapper. It's not the worst I've seen, admittedly, but I just want to make note of it. It really just looks like the playback is being played in slow motion when dragging bonds around. Note that in reality my mouse was moving much quicker than what you see below:

MS01

Seen on Win 10 Chrome. For phetsims/qa/issues/635.

@liammulh
Copy link
Member

liammulh commented Apr 2, 2021

Not seeing this on macOS + Safari.

@jonathanolson
Copy link
Contributor

@zepumph I think it was discussed that playback performance wasn't something to optimize, correct? (The approach definitely rebuilds the view)

@zepumph
Copy link
Member

zepumph commented May 5, 2021

Yes. I have not yet recommended any time to solve this in the past, and I don't think @samreid has either. In my opinion, the playback wrapper is a tool that we use to ensure that the recording are complete. It also serves as an example of what PhET-iO can accomplish. I don't think time needs to be devoted to this issue personally.

@zepumph
Copy link
Member

zepumph commented Mar 17, 2022

We won't be supporting the playback wrapper anymore, see https://github.com/phetsims/phet-io/issues/1854. Closing

@zepumph zepumph closed this as completed Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants