Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

surfaceTypeText.text should be a display name, not camelCase? #67

Closed
zepumph opened this issue Jul 19, 2017 · 1 comment
Closed

surfaceTypeText.text should be a display name, not camelCase? #67

zepumph opened this issue Jul 19, 2017 · 1 comment

Comments

@zepumph
Copy link
Member

zepumph commented Jul 19, 2017

from code review #30
In the RealMoleculesViewer, I am unsure about how to review, it is possible that much of this will change. No matter I'm pretty sure we don't want the surfaceType variable value to be the display name on the viewer.

    setSurfaceType: function( surfaceType ) {
      this.surfaceTypeText.text = ( 'surface: ' + surfaceType );
    }
@zepumph
Copy link
Member Author

zepumph commented Jul 19, 2017

I'm sorry! I now see that this display is part of the 'debugText' node. Closing!

@zepumph zepumph closed this as completed Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants