Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BondCharacterNode --> BondCharacterDisplayNode? #62

Closed
zepumph opened this issue Jul 18, 2017 · 1 comment
Closed

BondCharacterNode --> BondCharacterDisplayNode? #62

zepumph opened this issue Jul 18, 2017 · 1 comment
Assignees
@pixelzoom
Labels
type:question

Comments

@zepumph
Copy link
Member

zepumph commented Jul 18, 2017

From Code Review #30
This may be a bit clearer that you don't interact with this node, it just displays the 'character' of the molecule.
@pixelzoom
Copy link
Contributor

There's no precedent for having a different naming convention for things that are "display only". And I don't think it's particularly useful in this case. So I'm not going to change this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
type:question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @zepumph