Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the hyperlink on the Real Molecules screen be translatable? #41

Closed
zepumph opened this issue Jul 11, 2017 · 1 comment
Closed

Comments

@zepumph
Copy link
Member

zepumph commented Jul 11, 2017

as part of #30 (code review)
I don't mean this in the sense that the translators can edit the hyperlink, because I think that will just lead to cans of worms being freed. I am just wondering if we wanted to detect the local, and adjust the link accordingly to go to the correct language of the website. So for spanish the link would be

https://phet.colorado.edu/es/simulation/legacy/molecule-polarity

@pixelzoom
Copy link
Contributor

We decided not to allow translation of links because it's a security risk. The user will be directed to the main (English) sim page, where they can then select "Translations" to choose their language.

Closing as "won't fix".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants