Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate sound generation that is now supported by Slider #244

Open
jbphet opened this issue Mar 11, 2022 · 0 comments
Open

Integrate sound generation that is now supported by Slider #244

jbphet opened this issue Mar 11, 2022 · 0 comments

Comments

@jbphet
Copy link
Contributor

jbphet commented Mar 11, 2022

In phetsims/sun#697, generalized support for sound generation by sliders was added. The time was not taken to integrate this into all sims that were doing customized sound generation related to sliders, such as this one. Instead, the default sound was simply turned off via the options. Before this sin is released again off of master, we should consider integrating the now supported method slider sound generation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant