-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign the UI for selecting absorption wavelengths. #31
Comments
7/14/2022 design meeting:
Of all of the "design" issues, this one is highest priority, so keeping it labeled as "high-priority". |
Unassigning myself until work resumes on this sim. |
Some work on this was done in the design doc, and implemented in #35. There is now an "Absorption Wavelengths" info button. It opens a dialog, from which absorption wavelengths can be selected. @arouinfar and I also discussed displaying the associated transition next to the wavelength display whenever an absorption wavelength is set. It would be nice to mock this up, but I suspect that I might have it implemented before that happens :) |
I did indeed implement the Absorption Wavelengths dialog (test drive in main). But I did not implement a means of selecting wavelengths in that dialog, because I ran into many design questions. Big questions:
Less big questions:
Assigning to @DianaTavares and @arouinfar to get the design discussion going. |
Looks great @pixelzoom! |
Fist idea!: Absorption and emission panels, that last one as an info button in the Spectrometer. To fit the Absortion panel, I have to move all the play areas to the center, but now that I see the notes:
Then I will mock up that better. |
Hold off on the mockups @DianaTavares. I've run into some problems with the approach the we discussed in yesterday's design meeting. Too complicated to try to describe here (it has to do with switching between models, and between white/monochromartic), and we'll need to discuss again. In the meantime, there is one "Absorption/Emission" non-modal dialog. It's movable, and opened via a checkbox below the light controls. Screenshot: |
That looks like an AccordionBox. AccordionBox can be collapsed, but it never totally disappears. |
In today's design meeting with @arouinfar, @pixelzoom, @Nancy-Salpepi and @kathy-phet , we decided to continue with the idea of only one panel, Absorption/Emission, that is draggable: @pixelzoom will continue working in the implementation. Now this issue is the same as #32, can we close one of the issues? |
Thanks @DianaTavares. I think we can close both this issue and #32. When the sim is feature complete, we can reevaluate and (if needed) open a new issue for any changes that we'd like to make. |
Related to #1 (design refresh) and phetsims/scenery-phet#211 (wavelength slider)...
We currently do not have a wavelength slider that supports UV/IR wavelengths. UV is essential for MOTHA, and that enhancement will be made in phetsims/scenery-phet#211.
The Java vesion of wavelength slider had some additional functionality that appeared in the Java version of MOTHA. The slider track (spectrum) could be decorated with vertical lines that denote the absorption wavelengths. Here's what that looks like in the Java version of MOTHA. Note the vertical black lines at the left end of the spectrum - those are the absorption wavelengths.
As I noted in phetsims/scenery-phet#211 (comment) on 11/18/2015, I've never felt that this is a particularly effective way of denoting the absorption wavelengths. And this also gets low marks for usability -- it's very difficult to select specific wavelengths, they're all bunched together. That's a bit sad, since setting specific absorption wavelengths is an important part of making things happen in this sim.
So... Can we come up with a better UI for this in the design refresh? Assigning to the design team for brainstorming. I'll be needing this functionality by early September 2022, so high prioroity to get the discussion going.
The text was updated successfully, but these errors were encountered: