Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider UI for changing number of cups #66

Closed
pixelzoom opened this issue Jun 28, 2022 · 2 comments
Closed

Reconsider UI for changing number of cups #66

pixelzoom opened this issue Jun 28, 2022 · 2 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jun 28, 2022

For code review #41 ...

Some feedback on this control:

screenshot_1725

(1) I really don't like left-right spinners. Up-down is a much better UX, especially when considering right-to-left languages.

(2) I don't like using text labels where we don't need to.

So for this control... I think a NumberPicker (not a NumberSpinner) with a cup icon to the right of it would accurately describe what the control does. And it would be a better UX.

@marlitas
Copy link
Contributor

In this issue: #25 @amanda-phet determined the left-right NumberSpinner was preferable. This sim started with a NumberPicker and did not provide the desired result as determined by designers and dev team according to spacing as well as functionality with future screens.

Leaving issue open to address question of text label vs. icon. Removing assignment for designer feedback.

@marlitas marlitas removed their assignment Jun 29, 2022
@amanda-phet
Copy link
Contributor

Discussed 7/14/22 and would like to leave this control as-is. The text is helpful (e.g. if a teacher is discussing how to calculate the mean, they would say "divide by the total number of cups" or "devide by the number of cups"), and adding another cup to the screen could be too many cups.

The discussion about the number control happened in a previous issue and meetings, and we prefer to use this control in this case because a vertical number picker will be confusing on a later screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants