You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
(1) I really don't like left-right spinners. Up-down is a much better UX, especially when considering right-to-left languages.
(2) I don't like using text labels where we don't need to.
So for this control... I think a NumberPicker (not a NumberSpinner) with a cup icon to the right of it would accurately describe what the control does. And it would be a better UX.
The text was updated successfully, but these errors were encountered:
In this issue: #25@amanda-phet determined the left-right NumberSpinner was preferable. This sim started with a NumberPicker and did not provide the desired result as determined by designers and dev team according to spacing as well as functionality with future screens.
Leaving issue open to address question of text label vs. icon. Removing assignment for designer feedback.
Discussed 7/14/22 and would like to leave this control as-is. The text is helpful (e.g. if a teacher is discussing how to calculate the mean, they would say "divide by the total number of cups" or "devide by the number of cups"), and adding another cup to the screen could be too many cups.
The discussion about the number control happened in a previous issue and meetings, and we prefer to use this control in this case because a vertical number picker will be confusing on a later screen.
For code review #41 ...
Some feedback on this control:
(1) I really don't like left-right spinners. Up-down is a much better UX, especially when considering right-to-left languages.
(2) I don't like using text labels where we don't need to.
So for this control... I think a NumberPicker (not a NumberSpinner) with a cup icon to the right of it would accurately describe what the control does. And it would be a better UX.
The text was updated successfully, but these errors were encountered: