Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few things about the "Sync" button #65

Closed
pixelzoom opened this issue Jun 28, 2022 · 4 comments
Closed

A few things about the "Sync" button #65

pixelzoom opened this issue Jun 28, 2022 · 4 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jun 28, 2022

For code review #41 ...

A few things about the "Sync" button...

(1) Does it really need to be labeled with "Sync", and that label will mean anything to users? "Sync" what? It didn't mean anything to me until I dug into the code. And I suspect it won't mean anything to the user until the play with it and figure it out. In which case the "Sync" label isn't doing anything.

(2) Why is the font size so small, compared to the other UI controls? See below.

(3) The button feels a tad small, especially if you remove the "Sync" label.

screenshot_1724

@marlitas
Copy link
Contributor

Unsure if consolidating this issue with: #35 would be useful. Different question, but same component. Referenced to connect both issues, and leaving open until more feedback and discussion is had.

Removing assignment for designer feedback.

@marlitas marlitas removed their assignment Jun 29, 2022
@amanda-phet
Copy link
Contributor

(1) The button seemed strange without a word next to the icon (the size and alignment didn't look great, and the word seemed to add some meaning to what the button would do). We will definitely look for issues with this in interviews.

(2) I didn't notice the font size, but I'm fine with making it full size.

Let's pixel polish this when #35 is settled.

@marlitas
Copy link
Contributor

Putting light on this issue now that #35 has been settled. The font size has also been corrected to match other text.

@amanda-phet let me know if there are further pixel polishes you would like with this button.

@amanda-phet
Copy link
Contributor

I think this can be closed now. Thanks @pixelzoom and @marlitas !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants