You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
(1) Does it really need to be labeled with "Sync", and that label will mean anything to users? "Sync" what? It didn't mean anything to me until I dug into the code. And I suspect it won't mean anything to the user until the play with it and figure it out. In which case the "Sync" label isn't doing anything.
(2) Why is the font size so small, compared to the other UI controls? See below.
(3) The button feels a tad small, especially if you remove the "Sync" label.
The text was updated successfully, but these errors were encountered:
Unsure if consolidating this issue with: #35 would be useful. Different question, but same component. Referenced to connect both issues, and leaving open until more feedback and discussion is had.
(1) The button seemed strange without a word next to the icon (the size and alignment didn't look great, and the word seemed to add some meaning to what the button would do). We will definitely look for issues with this in interviews.
(2) I didn't notice the font size, but I'm fine with making it full size.
For code review #41 ...
A few things about the "Sync" button...
(1) Does it really need to be labeled with "Sync", and that label will mean anything to users? "Sync" what? It didn't mean anything to me until I dug into the code. And I suspect it won't mean anything to the user until the play with it and figure it out. In which case the "Sync" label isn't doing anything.
(2) Why is the font size so small, compared to the other UI controls? See below.
(3) The button feels a tad small, especially if you remove the "Sync" label.
The text was updated successfully, but these errors were encountered: