We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For code review #41 ...
super.dispose is typically called after doing any subclass-specific disposal. This sim is doing the opposite.
super.dispose
For example in WaterCup3DNode.ts:
public override dispose(): void { super.dispose(); this.waterLevelTriangle.dispose(); this.adapterProperty.dispose(); this.introModel.isShowingTickMarksProperty.unlink( this.showTickMarksLink ); this.cup3DModel.resetEmitter.removeAllListeners(); }
Search for super.dispose, I think the order is reversed everywhere.
The text was updated successfully, but these errors were encountered:
Since moving everything to static allocation, disposal is no longer required for any of the elements in this screen. Closing.
Sorry, something went wrong.
marlitas
No branches or pull requests
For code review #41 ...
super.dispose
is typically called after doing any subclass-specific disposal. This sim is doing the opposite.For example in WaterCup3DNode.ts:
Search for
super.dispose
, I think the order is reversed everywhere.The text was updated successfully, but these errors were encountered: