Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon for Lab screen no longer accurate #374

Open
KatieWoe opened this issue May 5, 2023 · 3 comments
Open

Icon for Lab screen no longer accurate #374

KatieWoe opened this issue May 5, 2023 · 3 comments

Comments

@KatieWoe
Copy link
Contributor

KatieWoe commented May 5, 2023

Test device
Samsung
Operating System
Win 11
Browser
Chrome
Problem description
For phetsims/qa#936
The masses on the lab screen are now different colors than they were in published. They were red and blue, and are now pink and cyan. This was likely done to accommodate color blind vision. However, it does mean the mass in the icon for the lab screen does not match any of the actual masses on that screen.

Visuals
labicon

Troubleshooting information:

!!!!! DO NOT EDIT !!!!!
Name: ‪Masses and Springs‬
URL: https://phet-dev.colorado.edu/html/masses-and-springs/1.1.0-dev.2/phet/masses-and-springs_all_phet.html
Version: 1.1.0-dev.2 2023-05-02 23:06:13 UTC
Features missing: applicationcache, applicationcache, touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/112.0.0.0 Safari/537.36
Language: en-US
Window: 1536x714
Pixel Ratio: 1.25/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 31 uniform: 4096
Texture: size: 8192 imageUnits: 32 (vertex: 32, combined: 64)
Max viewport: 8192x8192
OES_texture_float: true
Dependencies JSON: {}

@arouinfar
Copy link

Good catch @KatieWoe. Looks like the screen icons are artwork, so I'll take care of updating it.

@arouinfar
Copy link

I updated the color of the mass to match the one used in the sim. @jbphet here are the updated assets:
updated-lab-screen-icon.zip

labScreenIcon

@arouinfar arouinfar assigned jbphet and unassigned arouinfar Jun 1, 2023
@jbphet
Copy link
Contributor

jbphet commented Jul 20, 2023

Unassigning and marking as "blocks-sim-publication" since the republication of this sim has been deprioritized for now. This should be addressed (at least to some degree) before republishing.

@jbphet jbphet removed their assignment Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants