From 38d522504e8ae984cb1e08ce3c35cd38b0ca3e93 Mon Sep 17 00:00:00 2001 From: denz1994 Date: Wed, 30 Jan 2019 12:02:20 -0500 Subject: [PATCH] Addressed REVIEW: Fixing shelfNode references. https://github.com/phetsims/masses-and-springs-basics/issues/48 --- js/common/view/{Shelf.js => ShelfNode.js} | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) rename js/common/view/{Shelf.js => ShelfNode.js} (78%) diff --git a/js/common/view/Shelf.js b/js/common/view/ShelfNode.js similarity index 78% rename from js/common/view/Shelf.js rename to js/common/view/ShelfNode.js index 26447dba..60d4b3a1 100644 --- a/js/common/view/Shelf.js +++ b/js/common/view/ShelfNode.js @@ -17,9 +17,8 @@ define( function( require ) { * @param {Tandem} tandem * @param {Object} [options] * @constructor - * REVIEW: ShelfNode might be a better name? `Shelf` seems like the model name */ - function Shelf( tandem, options ) { + function ShelfNode( tandem, options ) { options = _.extend( { fill: '#e6c29a', stroke: 'black', @@ -31,7 +30,7 @@ define( function( require ) { Rectangle.call( this, options ); } - massesAndSprings.register( 'Shelf', Shelf ); + massesAndSprings.register( 'ShelfNode', ShelfNode ); - return inherit( Rectangle, Shelf ); + return inherit( Rectangle, ShelfNode ); } ); \ No newline at end of file