From 34b65aa8f6252d70e7d73fc048ff1c6b50be55ee Mon Sep 17 00:00:00 2001 From: denz1994 Date: Tue, 13 Mar 2018 14:08:32 -0400 Subject: [PATCH] Updated Ceiling_Y constant. #253 --- js/common/MassesAndSpringsConstants.js | 2 +- js/common/model/MassesAndSpringsModel.js | 5 +---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/js/common/MassesAndSpringsConstants.js b/js/common/MassesAndSpringsConstants.js index 8f549089..b805a2df 100644 --- a/js/common/MassesAndSpringsConstants.js +++ b/js/common/MassesAndSpringsConstants.js @@ -30,7 +30,7 @@ define( function( require ) { FLOOR_Y: 0, // Y position of ceiling in meters. The ceiling is the top of the SpringHangerNode, just below the top of the dev view bounds - CEILING_Y: 1.48, + CEILING_Y: 1.47, // {Property.} range of damping associated with sim //RVEIEW: If exposing only Range, don't use a RangeWithValue? (or if used, document as such) diff --git a/js/common/model/MassesAndSpringsModel.js b/js/common/model/MassesAndSpringsModel.js index 18b8ff24..48ba9d48 100644 --- a/js/common/model/MassesAndSpringsModel.js +++ b/js/common/model/MassesAndSpringsModel.js @@ -197,10 +197,7 @@ define( function( require ) { */ createSpring: function( x, tandem ) { var spring = new Spring( - //REVIEW: Is the 0.01 an important constant? - //REVIEW: Might be related to this comment in DisplacementArrowNode: - //REVIEW: TODO: We should find out why this -0.01 is outside the modelViewTransform. It can be negative but why is the number value there? @denz1994 - new Vector2( x, MassesAndSpringsConstants.CEILING_Y - 0.01 ), + new Vector2( x, MassesAndSpringsConstants.CEILING_Y ), MassesAndSpringsConstants.DEFAULT_SPRING_LENGTH, this.dampingProperty.get(), tandem